Giter Site home page Giter Site logo

Comments (2)

dtretyakov avatar dtretyakov commented on June 2, 2024

@tg73, the NUGET_XMLDOC_MODE=skip setting comes from the original docker images provided by Microsoft, e.g: https://github.com/dotnet/dotnet-docker/blob/master/2.1/sdk/nanoserver-1803/amd64/Dockerfile

If you need different setting you could easily create derived image from jetbrains/teamcity-agent or define required env.NUGET_XMLDOC_MODE environment parameter in your build configuration.

from teamcity-docker-agent.

tg73 avatar tg73 commented on June 2, 2024

@dtretyakov, I'm slightly confused: for example, https://github.com/JetBrains/teamcity-docker-agent/blob/master/windowsservercore/Dockerfile appears to be based on microsoft/dotnet-framework:4.7.2-sdk-windowsservercore-$TAG, which comes from https://github.com/Microsoft/dotnet-framework-docker/blob/master/4.7.2-windowsservercore-1803/sdk/Dockerfile, which is based on microsoft/dotnet-framework:4.7.2-runtime-windowsservercore-1803 which comes from https://github.com/Microsoft/dotnet-framework-docker/blob/master/4.7.2-windowsservercore-1803/runtime/Dockerfile, which is based on microsoft/windowsservercore:1803. None of those Dockerfiles introduce NUGET_XMLDOC_MODE=skip. None of those are based on microsoft/dotnet (which comes from the url you mentioned https://github.com/dotnet/dotnet-docker/blob/master/2.1/sdk/nanoserver-1803/amd64/Dockerfile), and the actual ENV directive appears to be introduced for the first time in https://github.com/JetBrains/teamcity-docker-agent/blob/master/windowsservercore/Dockerfile.

It's still not clear to me why having this setting in a general-purpose TC agent image is a good idea, notably when compared to the general TC documentation. For my own purposes, I've had to create my own Dockerfile "flattened" all the way down including the content microsoft/dotnet-framework:4.7.2-sdk Dockerfile because our builds need additional workloads from the buildtools installer, and despite my best efforts I could not successfully get the buildtools installer to add further components to the existing installation - so instead we add what we need from the very beginning. So I can of course use my desired setting. I'm raising the issue because it might be a subtle pitfall for other users.

from teamcity-docker-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.