Refactor open-next e2e tests to be compatible with Multi Site

[bestickley]

Refactor open-next e2e tests to be compatible with Multi Site

[onhate]

I see your point, it makes sense

[bestickley]

@onhate, on second thought, I think we should try to refactor the open-next e2e tests such that a base path can be specified that won't break NextjsSite's usage of the tests and will enable use to test multi-site. We'll still have to figure out specifying basePath (maybe a script that automatically updates next.config.ts?) but I think benefitting from upstream updates in open-next is more valuable than benefits we gain from pulling into our own repo.

[onhate]

It looks like that writing our own apps for the e2e are worth, they don't need to be complex apps, mostly one or two routes to validate things

[bestickley]

You think it will be worth it to write our own apps and e2e tests? I agree they don't need to be complex, but we'll definitely need more than 1-2 routes. Check out the open-next example apps and see how many Next.js features are being tested. That's why I think we should work with open-next team so we both benefit instead of separately doing the same thing. Let me know what you think.