Passing whole config object in c3chart directive

[jettro]

Passing whole config object in c3chart directive

[jettro]

It is harder to decide when to start drawing the chart if I would pass the config. Should I wait before drawing or not. I made the decision to provide acces to the c3 API methods using a callback. Check this sample, maybe that is enough for you:

https://github.com/jettro/c3-angular-directive/blob/master/examples/callback-sample.html

[jonchenn]

Well, the config attribute can be pass as a base config object. Similr to the empty config object you have in controller: https://github.com/jettro/c3-angular-directive/blob/master/src/controller.js#L37. Other attributes can override the base config, and construct the final config and draw the graph as it does today.

By overriding the entire config would provide more granular control of the chart, also keep up with the latest C3 spec.

However this might be a minority use case. Feel free to close this issue if it doesn't provide too much value.

[jettro]

I would like the framework to be flexible, I understand what you mean. Going to think about it a bit more. If it helps people I wouldn't mind. Thanks for the idea

[sajidali]

@jettro I believe this suggestion will help a lot, allowing to provide base config will go a long way hopefully.
I would love to have this feature.

[jettro]

Fixed, you can now provide an initial c3 config object using the chart directive.

[sajidali]

Thank you @jettro

[sajidali]

URL not working any more.
"Check this sample, maybe that is enough for you:
https://github.com/jettro/c3-angular-directive/blob/master/examples/callback-sample.html"

[jettro]

You are right, did a big refactoring of the samples, you can find the running examples here:
http://jettro.github.io/c3-angular-directive/examples/index.html#/dashboard