Giter Site home page Giter Site logo

Unmatched quote in value causes AbstractLineData::parse to try to slurp up whole file before continuing to next line about batch-import HOT 3 CLOSED

jexp avatar jexp commented on August 17, 2024
Unmatched quote in value causes AbstractLineData::parse to try to slurp up whole file before continuing to next line

from batch-import.

Comments (3)

jexp avatar jexp commented on August 17, 2024

Any suggestion on what we can do? The importer now uses opencsv by default which allows multi-line entries in quotes.

from batch-import.

donaldguy avatar donaldguy commented on August 17, 2024

Minimally some amount of pitfall documentation. While I admit it is a common thing to CSV parsing, I didn't see anything about quotation in the readme, I assumed it was unsupported/not a concern until it caused a problem.

Given the insistence towards tab (^I) field-separation (and newline record separation), before I dove into the source, I generally assumed tokenization would be performed at the line and tab level, and that generally tabs and newlines would not be accepted as a character contained therein (at least not without explicit per-character escaping)

​If it is the aim to support inline tabs/new lines through quoting, that should probably be documented. Or more aggressively, perhaps a warning should be logged when such are encountered. 

Really the main problem was that this happened within the first 10000 records, so I had no output beyond a usage note and "Using existing configuration file", and couldn't tell if anything was happening at all until I attached a debugger

from batch-import.

fredbenenson avatar fredbenenson commented on August 17, 2024

Just wanted to say I ran into this as well, and it also took quite a big of debugging to figure it out, so I'm with @donaldguy re: pitfall documentation.

I also agree that Iif you're doing a batch-import, it is perfectly reasonable to assume that individual rows / entries are new-line delimited (many other massive import tools do this), so maybe there's away to turn that "feature" off in opencsv.

Otherwise, thanks for the great tool!

from batch-import.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.