TESTS: expect_true(inherits(plan(), 'sequential')) -> expect_true(identical(plan(), oplan))

[HenrikBengtsson]

TESTS: expect_true(inherits(plan(), 'sequential')) -> expect_true(identical(plan(), oplan))

[jfiksel]

Ah, got it. Ok this should now actually be fixed with 8b48c71

[HenrikBengtsson]

Actually, it should be:

oplan <- plan("list")
...
expect_true(identical(plan(), oplan))

[jfiksel]

Hi Henrik, thank you for taking the time to let us know about this issue. However, even after installing the version of the future package on your GitHub (version 1.19.1), just running

library(future)
oplan <- plan("list")
identical(plan(), oplan)

returns FALSE, while running

library(future)
oplan <- plan()
identical(plan(), oplan)

returns TRUE. So it seems like your most recent comment would cause an error in the testing script, but let me know if this seems wrong.

[HenrikBengtsson]

My bad (again), should be:

library(future)
oplan <- plan("list")
identical(plan("list"), oplan)

[jfiksel]

Excellent, this has been fixed with commit ac0eaa9. Thanks for your help!

[HenrikBengtsson]

Almost. Right now you're basically testing identical(plan("list"), plan("list")), no different than testing identical(1, 1). You need to record:

oplan <- plan("list")

at the beginning, before you call your functions that set plan() internally. You can test that it works by setting the environment variable R_FUTURE_PLAN=multisession before running your tests.