Giter Site home page Giter Site logo

Comments (5)

jfkirk avatar jfkirk commented on May 23, 2024

@ThoseGrapefruits you expressed interest via Slack -- let me know if you want to take a stab at this!

from tensorrec.

ThoseGrapefruits avatar ThoseGrapefruits commented on May 23, 2024

Yep, sounds good!

from tensorrec.

ThoseGrapefruits avatar ThoseGrapefruits commented on May 23, 2024

Not sure when you’re getting back from πŸ‡ΈπŸ‡ͺπŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦πŸ”¨ but I have a couple intro questions already:

  1. What’s the workflow for setting up the environment and running tests? I’ve been out of the Python environment for too long and all I remember is pip install -r requirements.txt and I’m not sure even that is right in this context.
  2. Any style requirements? I noticed a 120-char line limit seems standard.
  3. What version of Python is this using? I don't want to start using 3.4-6 features if this is meant to be in 2.x.

from tensorrec.

jfkirk avatar jfkirk commented on May 23, 2024

Hey @ThoseGrapefruits !

  1. After cloning, you should be able to run the tests by stepping through
pip install -r requirements.txt
pip install -r requirements_test.txt
nosetests test/
  1. 120-char line limit is correct (you can find it defined in setup.cfg). Beyond that, if Flake passes I'm probably comfortable with the style. I'm also a big fan of NumPy's commit message standards: https://docs.scipy.org/doc/numpy-1.13.0/dev/gitwash/development_workflow.html

  2. Currently TensorRec is checked for compatibility with Python 2.7 and 3.6.1 -- either one should work for your development, just make sure to check both (Travis will check both on your PR, too).

Thanks!

from tensorrec.

ThoseGrapefruits avatar ThoseGrapefruits commented on May 23, 2024

All sounds good.

I got it working in a virtualenv, but had to use python -m nose test/ to run tests instead. Anyways, it works, and all 58 tests passed for me. Thanks!

I'll let you know when I have other questions :)

from tensorrec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.