Giter Site home page Giter Site logo

Comments (7)

DevCharly avatar DevCharly commented on May 30, 2024

Yes, that should be not that difficult to implement and is a nice improvement 👍

from flatlaf.

DevCharly avatar DevCharly commented on May 30, 2024

This is now implemented in master branch.

image

To enable it use:

UIManager.put( "TableHeader.sortIconPosition", "top" );

"bottom" and "left" are also supported:
image image

from flatlaf.

Chrriis avatar Chrriis commented on May 30, 2024

@DevCharly Thanks for the fix, it is almost perfect! 🙂 When the arrow is at the top, I feel it is too close to the text. I think it would look better if it were 1 pixel up.
See this comparison "now vs 1px up":
FlatLafTopSortArrowPosition

from flatlaf.

Chrriis avatar Chrriis commented on May 30, 2024

I am not concerned by right-to-left support. Still, I am curious: how does the table behave in RTL mode, and what does "left"/"right" sort position mean in that case? Should you also support "leading" and "trailing" positions then?

from flatlaf.

DevCharly avatar DevCharly commented on May 30, 2024

Thanks for your feedback. I've optimized the position of the top arrow.
Also fixed the position of the chevron style arrow, which was not at the same position as the triangle arrow.

Regarding RTL: this is indeed not supported. I've tested all system LaFs (on Windows and macOS) and some popular open-source LaFs, but all of them ignore RTL for the sort arrow position. So right now, I think I leave it as it is...

from flatlaf.

Chrriis avatar Chrriis commented on May 30, 2024

Hi @DevCharly, I tried the chevron top position earlier today and it is much better. Thanks again for your work!

from flatlaf.

DevCharly avatar DevCharly commented on May 30, 2024

released in 0.27

from flatlaf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.