Underlined toggle button height

[Chrriis]

Underlined toggle button height

[DevCharly]

Setting minimum height with client property JComponent.minimumHeight (or FlatClientProperties.MINIMUM_HEIGHT) is now implemented in master branch.

Do you think that a global value in the UI defaults is also necessary/useful?

[Chrriis]

I don't think it is necessary, and I don't know if it could be useful. Because underline is not the default style for a button, it requires code to activate it, so if someone wants a different height, they could make a factory method.

[Chrriis]

I just tried the code, but I would have thought the preferred size is the one that needs attention. How would you change my test case so that the button is taller (that means having the underline lower)?

[DevCharly]

Must admit that I've not tested the change with your code.

It does not work in your example because the JToggleButton is a child of a JToolBar and such children do not get "minimum preferred" width/height.

FlatLaf/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatButtonUI.java

Lines 387 to 391 in 74909da

	else if( !isToolBarButton( c ) && c.getBorder() instanceof FlatButtonBorder ) {
	int focusWidth = getFocusWidth( c );
	prefSize.width = Math.max( prefSize.width, scale( FlatUIUtils.minimumWidth( c, minimumWidth ) + (focusWidth * 2) ) );
	prefSize.height = Math.max( prefSize.height, scale( FlatUIUtils.minimumHeight( c, 0 ) + (focusWidth * 2) ) );
	}

The purpose of the "minimum preferred" width is that buttons with short text (e.g. "OK") or empty text fields have a useful width by default. If a button is in a toolbar, it should be smaller.

Anyway there is a better way to give the button a larger size:

button1.setMargin( new Insets( 10, 10, 10, 10 ) );

[DevCharly]

implemented in 0.26