Friends nicknames gets "obfuscated"

[jfreegman]

Friends nicknames gets "obfuscated"

[JFreegman]

It looks like it's reading garbage from a buffer. What client is he using? Could you ask him to change his name and see if the problem persists?

[Brottweiler]

He uses Venom.

He changed his username, and in the title and the tab bar, it said his new name. However, the chat window still said his obfuscated name whenever he typed messages.

I even restarted Toxic, and it said
[23:26:12] * ~X~A~(~\^^A has come online

In the friends list:
> O DINOISGOD

In the chat window:
[23:26:16] Brottweiler: test [23:27:18] : testetstetstets

Now, apparently, he has no name at all. It's blank.

Restarted Toxic again, now his name is X^B, so... same thing still, I guess.

[JFreegman]

This probably has to do with the recent toxcore change. It seems like venom isn't null terminating the name. I don't think it's a toxic issue: https://github.com/Tox/toxic/blob/master/src/friendlist.c#L137

If you know how to use gdb you could try inspecting the name buffer to see where the null is placed.

Also, to be sure, you could ask him to try toxic with the same data file (should use the same by default).

[JFreegman]

I just added some null forcing just in case. Could you let me know if the problem persists?

[Brottweiler]

I just added and PMd a friend who also uses Toxic, his name is also obfuscated;
[00:23:20] ^P^K> : hshgfiu [00:23:44] ^P^K> : HYPE

[Brottweiler]

Right now, may or may not been since r800, but I see no nicknames in the PM window. At the top, it just sais [Online]. Bottom, sais [] when it should say their nickname between the brackets, and in the actuall chat window it sais just ":" before their message.

[JFreegman]

Does it happen when your friend uses toxic?

[Brottweiler]

One of them uses Venom, the other uses Toxic. But my friend who used Toxic (well actually both of them) said that it was normal for them. Only I seem to have the problem. Can it be because of my data file? I can try make a new one and see what happens.

[JFreegman]

Yes, that would be helpful. Make sure to add the same friend with the weird name. If it's only him that the problem occurs with it's probably not a toxic issue.

[Brottweiler]

I just made a new data file, let my friend add me. Same problem. Now, he got a nick again though, but it is obfuscated yet again.

My other friend, does use Toxic too, and it happens with him too. But it seems to only happen for me. For my friend who uses Toxic, he seems to not have the same problem as I. I am not sure what's going on. >.<

Edit: To clarify, I have 3 friend. One uses Venom, one Toxic, the third is also using Toxic since it is a groupbot. When I open a PM window with each, all of them have an obfuscated name.

[Brottweiler]

Nicknames seems fine in groupchats;

PM:
[22:02:13] Brottweiler: test [22:02:24] ^Pg~: fg

Groupchat:
[22:02:36] * Anonymous has joined the room [22:02:39] : hello [22:02:45] * Anonymous is now known as firstvirus92 [22:02:54] firstvirus92: hello

[Brottweiler]

Hmm... It does appear that this is fixed for me now. I am not sure if it was a commit and in that case which one, or something else. But I am no longer seeing obfuscated names, they are normal.

[JFreegman]

All inbound strings in toxic are now force null terminated. That's probably what fixed it.