Comments (13)
It looks like it's reading garbage from a buffer. What client is he using? Could you ask him to change his name and see if the problem persists?
from toxic.
He uses Venom.
He changed his username, and in the title and the tab bar, it said his new name. However, the chat window still said his obfuscated name whenever he typed messages.
I even restarted Toxic, and it said
[23:26:12] * ~X~A~(~\^^A has come online
In the friends list:
> O DINOISGOD
In the chat window:
[23:26:16] Brottweiler: test [23:27:18] : testetstetstets
Now, apparently, he has no name at all. It's blank.
Restarted Toxic again, now his name is X^B
, so... same thing still, I guess.
from toxic.
This probably has to do with the recent toxcore change. It seems like venom isn't null terminating the name. I don't think it's a toxic issue: https://github.com/Tox/toxic/blob/master/src/friendlist.c#L137
If you know how to use gdb you could try inspecting the name buffer to see where the null is placed.
Also, to be sure, you could ask him to try toxic with the same data file (should use the same by default).
from toxic.
I just added some null forcing just in case. Could you let me know if the problem persists?
from toxic.
I just added and PMd a friend who also uses Toxic, his name is also obfuscated;
[00:23:20] ^P^K> : hshgfiu [00:23:44] ^P^K> : HYPE
from toxic.
Right now, may or may not been since r800
, but I see no nicknames in the PM window. At the top, it just sais [Online]. Bottom, sais [] when it should say their nickname between the brackets, and in the actuall chat window it sais just ":" before their message.
from toxic.
Does it happen when your friend uses toxic?
from toxic.
One of them uses Venom, the other uses Toxic. But my friend who used Toxic (well actually both of them) said that it was normal for them. Only I seem to have the problem. Can it be because of my data file? I can try make a new one and see what happens.
from toxic.
Yes, that would be helpful. Make sure to add the same friend with the weird name. If it's only him that the problem occurs with it's probably not a toxic issue.
from toxic.
I just made a new data file, let my friend add me. Same problem. Now, he got a nick again though, but it is obfuscated yet again.
My other friend, does use Toxic too, and it happens with him too. But it seems to only happen for me. For my friend who uses Toxic, he seems to not have the same problem as I. I am not sure what's going on. >.<
Edit: To clarify, I have 3 friend. One uses Venom, one Toxic, the third is also using Toxic since it is a groupbot. When I open a PM window with each, all of them have an obfuscated name.
from toxic.
Nicknames seems fine in groupchats;
PM:
[22:02:13] Brottweiler: test [22:02:24] ^Pg~: fg
Groupchat:
[22:02:36] * Anonymous has joined the room [22:02:39] : hello [22:02:45] * Anonymous is now known as firstvirus92 [22:02:54] firstvirus92: hello
from toxic.
Hmm... It does appear that this is fixed for me now. I am not sure if it was a commit and in that case which one, or something else. But I am no longer seeing obfuscated names, they are normal.
from toxic.
All inbound strings in toxic are now force null terminated. That's probably what fixed it.
from toxic.
Related Issues (20)
- Using Telugu characters as nick will cause the interface for every user to mess up HOT 1
- show_group_connection_msg=false not working HOT 1
- OS X install instruction not working HOT 1
- Why is toxic connecting to 127.0.0.1:23075 a 1000 times an hour? HOT 2
- feature suggestion: better use of the Contacts top line HOT 1
- netprof branch does not compile HOT 1
- "Consider helping the Tox network by running toxic with -T, --tcp-relay" HOT 2
- feature request: ftp/filesharing available in text and voice conference HOT 6
- Notification for change of day HOT 1
- Topic bar HOT 2
- Error when run HOT 3
- Page-Up/Page-Down should page up and down HOT 3
- Compilation errors on FreeBSD / clang: missing header? HOT 8
- Fedora - Incorrect missing libraries. HOT 2
- feat: add optional nickname argument to /join command HOT 1
- tox.chat is distributing toxic with CVE vulnerabilities HOT 2
- Can't go online on one of my computers HOT 9
- 0.13.1 fails to build against `toxcore` master: `groupchats.c: error: too many arguments to function ‘tox_group_send_message’` HOT 2
- error: start again
- Issues Building; HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toxic.