fails to build when tox-core was built with nacl instead of libsodium

[jfreegman]

fails to build when tox-core was built with nacl instead of libsodium

[hasufell]

tox-core config.log https://gist.github.com/hasufell/db0e96d9fbac7bbe2e9a
toxic config.log https://gist.github.com/hasufell/1d8befb896348ddb366c

[stqism]

Mind trying this again, but compile toxcore as a static library?

[devurandom]

Could this be an issue similar to #47?

[stqism]

Mind testing this again? So I know if it can be closed.

Is this solved?

[thierry-FreeBSD]

FYI, I use the following patch in Tox to build venom correctly with NaCl in FreeBSD:

--- patch-libtoxcore.pc.in begins here ---
--- libtoxcore.pc.in.orig 2014-02-22 23:52:26.000000000 +0100
+++ libtoxcore.pc.in 2014-02-25 09:32:35.000000000 +0100
@@ -7,6 +7,6 @@
Description: Tox protocol library
Requires:
Version: @PACKAGE_VERSION@
-Libs: -L${libdir} -ltoxcore @libs@
+Libs: -L${libdir} -ltoxcore @NACL_LIBS@ @libs@
Cflags: -I${includedir}

--- patch-libtoxcore.pc.in ends here ---

But this does'nt work with Toxic.

[jin-eld]

I did some tuning to the core, basically I was told that when core is built vs nacl, the shared version of core should be disabled. I fixed pkg-config (i.e. also added NACL_LIBS) and set up core's configure in a way that it will automatically disable shared-library build if nacl is enabled.

Does it still fail with today's combination of core/toxic? I was trying to set up a BSD vm so I could have a look but did not succeed at getting BSD running properly/setting up a dev environment, if you have a shell for me where I could test, I'd appreciate it.

[jin-eld]

On Wed, Mar 19, 2014 at 02:20:24PM -0700, Thierry Thomas wrote:

Thanks for this update. I have to tried to check it, but it's not buildable
ATM, too many errors: log available at https://gist.github.com/thierry-FreeBSD/
9651558 if needed.

Uhm.. this gist is empty... are you sure you got the correct link?

[thierry-FreeBSD]

I removed it with my answer - but too late since you got it!

I found the reason: Tox-Core's API changed, and it must rebuilt too.

[thierry-FreeBSD]

Sorry for the delay... Here are the results of my tests.

With `pkg-config --libs libtoxcore' returning:

-L/usr/local/lib -ltoxcore -lnacl /usr/local/lib/cpucycles.o /usr/local/lib/randombytes.o

Venom links fine, but toxic fails with the message:

--- toxic ---
CCLD toxic
/usr/local/lib/randombytes.o: In function randombytes': randombytes-impl.c:(.text+0x0): multiple definition ofrandombytes'
/usr/local/lib/libnacl.a(randombytes.o):randombytes-impl.c:(.text+0x0): first defined here
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [toxic] Error code 1

When `pkg-config --libs libtoxcore' only returns:

-L/usr/local/lib -ltoxcore -lnacl

toxic builds fine, and Venom still builds!

[jin-eld]

Thanks, I think I now know what the problem is, those static files should not appear in the .pc file at all, I'll submit a PR to toxcore to fix that.

[jin-eld]

I did a few more tests, basically it seems that on linux the object files are needed when linking applications vs. a nacl-based toxcore, at the same time this seems to cause linking errors on freebsd systems.

Toxcore configure script will be tuned in the way that it will add the object files to the .pc on linux but not do so on freebsd, this should hopefully resolve this issue. Pleae test as soon as the toxcore PR gets merged: irungentoo/toxcore#815
Thanks.

[thierry-FreeBSD]

It's OK.

But I have a question: why did you disable the shared lib in tox when NaCl is enabled?

[jin-eld]

On Tue, Mar 25, 2014 at 03:12:36PM -0700, Thierry Thomas wrote:

It's OK.

But I have a question: why did you disable the shared lib in tox when NaCl is
enabled?

Actually I had errors when building shared toxcore libs vs. a static NaCl
library, after consulting with #tox-dev it was explained to me that the
correct way is to disable the shared lib build of toxcore when using NaCl.

My tests and observations confirmed that. Correct me if I'm wrong...

[thierry-FreeBSD]

During my previous tests on FreeBSD, I've been building a shared lib for tox, and venom was OK.

[jin-eld]

On Tue, Mar 25, 2014 at 03:43:17PM -0700, Thierry Thomas wrote:

During my previous tests on FreeBSD, I've been building a shared lib for tox,
and venom was OK.

I'll try again, but I mainly followed the suggestion in the channel since I
was not familiar with NaCl myself.