Comments (5)
Please supply correct details based on these specs: https://home.miot-spec.com/spec/roborock.vacuum.s5
It's currently implemented lik this:
1: 101: Quiet
2: 102: Standard
3: 103: Medium
4: 104: Turbo
5: 105: Max
I wont change the names, because they keep changing them on every new model and I cant create a custom capability for each model.
from com.xiaomi-miio.
Those specs are outdated or incomplete as it misses the Gentle value.
S5 has no Medium value and that is breaking it.
I understand that you are trying to use one common list, but your list is missing Gentle (Off) value representation.
I think it would be the best to have fan speeds related to a model.
Otherwise, I see the only solution to add one more value and duplicate some values.
For example:
Id | Spec | Setting | S5 Setting
0 | 105 | Gentle | Gentle
1 | 101 | Quiet | Silent
2 | 102 | Standard | Balanced
3 | 102 | Medium | Balanced
4 | 103 | Turbo | Turbo
5 | 104 | Max | Max
from com.xiaomi-miio.
I think it would be the best to have fan speeds related to a model.
Feel free to submit a PR where you create a custom capability to match each model. It wont be added by me as I have beter things to do with my life.
Otherwise, I see the only solution to add one more value and duplicate some values.
That would be the best solution for you. I have to consider about 12000 other users that also only think from their own perspective. I'll keep this request open to see if more users are missing this.
from com.xiaomi-miio.
I can see your point.
However, I am curious. You think it is fine/better how it is behaving right now?
-Right now, if you set S5 to Max, in real it is set to Gentle and that means, that instead using maximum power, it just drives around without any power. Not vacuuming at all.
from com.xiaomi-miio.
For now it's better for most users yes as I'm unsure other models have this gentle option. Changing it will affect a lot of users. I understand you only look at your own use case but I have to support 12000+ users. And I need to do all that in my free time without getting much appreciation for it anyway. So yes, I cut corners.
Just create your flows to use the right option even though the text doesn't match.
from com.xiaomi-miio.
Related Issues (20)
- Xiaomi smart humidifier unavailable HOT 1
- New Device Model: chuangmi.plug.m3 HOT 2
- New Device Support s7 max ultra (roborock.vacuum.a65) HOT 4
- Add more flow cards(set hunidity%, turn on/off light/sound etc.) in Homey for Smart Mi Antibacterial Humidifier JSQ5 HOT 14
- Add more card for rockrobo.vacuum.v1 HOT 7
- Add model roborock.vacuum.a51 (Roborock S8) HOT 3
- New Device Model: Mi Smart Plug (WiFi) EU HOT 3
- Add Flowcard swepping, moppping or booth as option for dreame.vacuum.r2228o HOT 3
- New Device Model Xiaomi Robot Vacuum X10 (dreame.vacuum.r2209) HOT 11
- Dreame Vacuum cleaner - set Rooms for cleanings HOT 13
- Add support for xiaomi.airp.cpa4 HOT 1
- Add support for chuangmi.camera.ipc009 HOT 9
- Add support dreame.vacuum.p2114a HOT 1
- [Bug] Chuangmi Plug HMI206 Power Plug Switch not working HOT 1
- Add support for careli.fryer.maf10a HOT 2
- Xiaomi smart plug 2 HOT 2
- Xiaomi lightstrip HOT 2
- Add support for dreame.vacuum.r2232c (Dreame L10s Prime) HOT 2
- Support for Mijia Smart Pet Food Feeder 2 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from com.xiaomi-miio.