Giter Site home page Giter Site logo

Comments (5)

jyyi1 avatar jyyi1 commented on June 12, 2024 1

Thanks @murka for the clarification. Yes, please feel free to draft new PRs. Thanks for the contribution!

from outline-server.

jyyi1 avatar jyyi1 commented on June 12, 2024

Hi @murka , both PR have been merged. Did this solve your issue? If so, please feel free to close this issue. Thanks.

from outline-server.

murka avatar murka commented on June 12, 2024

Hi, there!

Nope, the problem is not solved. So, I think I can PR-draft FYI.

from outline-server.

fortuna avatar fortuna commented on June 12, 2024

I'm trying to understand the need here.
What's wrong with the Ids not being reused? Ids are not supposed to be reused.

With #1473 you can import keys and use your own ID system.

Prometheus actually uses the key id, not the metricsId. metricsId is used for opt-in metrics to count unique keys. It's confusing though...

We use sequential numbers because we display the ID in case the key doesn't have a name "Key $ID", which is helpful in distinguishing the keys. UUIDs are less user friendly in that sense.

from outline-server.

murka avatar murka commented on June 12, 2024

So, you're all right, I think I can deprecate this PoC.

from outline-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.