Giter Site home page Giter Site logo

Comments (3)

JimmXinu avatar JimmXinu commented on June 1, 2024

Depends on the site. do_update_hook is only implemented for FimF and OTW sites(ie AO3), and it's basically deprecated for OTW sites since 2015. So I assume you're asking about a FimF story.

Story URL?

from fanficfare.

praschke avatar praschke commented on June 1, 2024

Fimfiction chapter URLs include the chapter title and index, so I believe chapters shifted in index by insertion or deletion are handled by the old chapter map similarly to AO3. In this case only in-place edits to chapters earlier in the list than the latest update would be missed.

Syosetu has only sequential indices in the URL, so the old chapter map would not be able to clean up after insertions or deletions. In this case you would get dropped or duplicated chapters with the described behavior, 'discard indices from the latest update'.

I see now that the update hook is called after the old chapter map is given to the adapter, but the only old metadata always accessible in the update hook (the log page is optional) is chapter's title, URL, and body text. But I also see now that the update hook is not always run, so access to the old chapter map doesn't have much point to me.

The only way I can see to correctly pick up updated chapters from syosetu is to give FFF chapter URLs modified to act as a unique key, by appending a query string constructed from the chapter title, publication date, and edit date.

from fanficfare.

JimmXinu avatar JimmXinu commented on June 1, 2024

This is a known limitation. If authors change the text of existing chapters, there's no way for FFF to know that in most cases. It's a relatively rare corner case, for what I've seen.

The answer, generally, is to overwrite instead of update in those cases. That's really the only solution that can address the problem for all sites.

I'm closing this since it isn't an issue with the software so much as a discussion of a future possible adapter.

from fanficfare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.