ng.pipe.make_uc() type error

[jjhelmus]

ng.pipe.make_uc() type error

[jjhelmus]

@hadwin-357 What version of NumPy do you have installed? I believe some of the recent releases are more strict about automatic type conversion.

[reneeotten]

I ran into a similar issue today with NumPy version 1.18.1. The problem is that linspace does not accept floats anymore for the number of samples to generate (this is the upstream NumPy commit).

Explicitly converting that argument to a int everywhere would work, but perhaps making sure that ._size is an integer makes more sense. The issue for me can be resolved by changing
self._size = size to self._size = int(size) on line 76 of fileio/fileiobase.py.

[reneeotten]

as a side-note there are two additional warnings about code in fileio/fileiobase.py:

/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/nmrglue/fileio/fileiobase.py:388: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if unit is 'ppm':
/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/nmrglue/fileio/fileiobase.py:391: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif unit is 'hz':

If you want I can make a PR to fix these at the same time.

[jjhelmus]

@reneeotten Thanks for looking into this issue. I agree, the size argument should be cast to an integer. I've implemented this and changed to string comparison to use an equality in #114.

In the future feel free to submit PRs for issues like these, I'd be happy to review them.

[reneeotten]

thanks @jjhelmus - I will submit a PR in the future. Are you planning to tag/release a new version soon-ish?

[jjhelmus]

Are you planning to tag/release a new version soon-ish?

It is about time for a release. I'll tag one later this week.