Comments (7)
should we do it in this PR or a new one?
@leinardi what does the change affect?
from ktlint-gradle.
@originx I think a new one is better. The changes are not in the method touched by #32.
But before creating one I'd like to hear from @Tapchicoma or @JLLeitschuh if they are interested in this.
from ktlint-gradle.
I don't personally use the output report.
I'd say that we should make the output configurable on the task but keep the default a sane configuration.
from ktlint-gradle.
It is a good idea, though checkstyle, for example, doesn't do this. It just aggregates everything in one file. Also this is more Android specific, though Gradle start to introduce SoftwareModel that will allow to have flavors on the plain Kotlin projects.
Also this feature should be configurable and disabled by default.
from ktlint-gradle.
With the current implementation if you run different tasks the output will be always the same file, and this file will be overwritten every time and not merged automatically. So, currently, you loose the report of all the tasks but the last executed.
I don't see what is the benefit of having it disabled by default. It will be useful if you execute different tasks and nothing will change if you only have one beside the name of the file itself.
The file is generate only for the tasks that you are actually executing and not for every variant you have.
In my example I have dozens of variants but I only run two tasks: ktlintNonpayItalyCompatDebugCheck and ktlintNonpayMexicoCompatDebugCheck.
from ktlint-gradle.
OK, I fear I've been misunderstood: I don't want to enable anything new related to the report output, I just want to generate the file name for the output in a different way. To make it more clear I have opened a pull request with my changes. This should have zero impact on non Android builds beside changing the name from reports/ktlint/ktlint.xml to reports/ktlint-reports-main.xml.
@Tapchicoma, @JLLeitschuh please have a look and if you have questions just let me know.
from ktlint-gradle.
Closed via #22
from ktlint-gradle.
Related Issues (20)
- Support custom SourceSets HOT 1
- Unexpected indentation for super type initialisation HOT 1
- Unexpected indentation (4) (should be 8) HOT 1
- Multiline-expression-wrapping rule breaks ktlintFormat HOT 3
- Function name should start with a lowercase letter for Composable Functions HOT 5
- Override rules for in-line comments and variables starting with underscore HOT 1
- Failing my builds if code isn't formatted HOT 3
- Ktlint Fails to Detect Formatting Issues in Nested Modules HOT 7
- Failing Builds Automatically HOT 1
- Same Issue HOT 6
- Cannot apply to buildSrc HOT 4
- Using this plugin with the official IntelliJ IDE plugin HOT 3
- K2 issue: A failure occurred while executing worker.KtLintWorkAction FILE HOT 2
- Ktlint checks generated source since 12.1.0 HOT 6
- Task KtlintMainSourceSetCheck failed HOT 2
- Task :runKtlintCheckOverMainSourceSet FAILED HOT 3
- import checks HOT 1
- Caches work incorrectly: additionalEditorconfig should be @Input instead of @Internal HOT 3
- Filter to exclude a generated dir is not working in version 12.1.0 HOT 3
- ktlint pre-commit hook HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ktlint-gradle.