Giter Site home page Giter Site logo

Comments (4)

LarsDenBakker avatar LarsDenBakker commented on May 14, 2024 1

@jlmakes thanks for your swift response.

I've set up a reproduction here: https://github.com/LarsDenBakker/karma-rollup-preprocessor-issues

Run:

npm install
npm run test:dynamic-import
optionally, debug the code at: http://localhost:9876/debug.html

You will see the dynamic import fail.

Adding them to the test config file will not work, as these files are generated by rollup itself when code splitting dynamic imports. Maybe this is out of scope for a preprocessor, but dynamic imports it becoming a very common code pattern. I expect it will be used more and more often.

Happy to help out where possible.

from karma-rollup-preprocessor.

jlmakes avatar jlmakes commented on May 14, 2024

I'm not sure this is within the purview of the preprocessor.
One idea is that the files are not declared in the Karma config as included: true.

Do you mind putting together a small repo demonstrating the problem?

from karma-rollup-preprocessor.

jlmakes avatar jlmakes commented on May 14, 2024

Thanks for the reproduction, can confirm npm run test:dynamic-import errors:

TypeError: Failed to fetch dynamically imported module: test-dynamic-import/bar-aed5ea93.js

I assumed Karma copied test files to a temp directory before serving them, and the dynamically imported files would be missing — but upon investigating, there only seems to be encoded/binary files in there.

I'm not sure how to proceed, but I'm suspicious this is more on the Karma side of things.

from karma-rollup-preprocessor.

isidrok avatar isidrok commented on May 14, 2024

Hi, its pretty possible that happens because calling bundle.generate creates several chunks but only the first one is returned as processed, which is the test file itself since they are ordered, so I see two options here:

  • If there is a way in Karma to output several files from inside a preprocessor just output all chunks.
  • If there isnt use the inlineDynamicImports rollup option.
  • Alternatively write all chunks to a temp folder or store them in memory and register a middleware in Karma to serve those files. This seems to be what the webpack preprocessor does (https://github.com/webpack-contrib/karma-webpack/blob/master/src/karma-webpack.js) but I think the second option is easier and should accomplish the same.

Cant confirm ATM though.

from karma-rollup-preprocessor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.