Giter Site home page Giter Site logo

Comments (5)

jlmelville avatar jlmelville commented on June 15, 2024 2

Ok I bought myself some time by removing a gradient instantiation

from uwot.

LTLA avatar LTLA commented on June 15, 2024

I don't recall seeing that many templates in your C++ code. Certainly it's not as bad as anything using Eigen or any of those header-only libraries floating around on CRAN. Surely they would be hit harder by template-related limitations.

from uwot.

jlmelville avatar jlmelville commented on June 15, 2024

It's a mingw problem it seems. Running devtools::load_all under Linux doesn't give a problem.

Good point about Eigen. Maybe it's because src/r_uwot.cpp basically generates all combinations of the templated classes: r_uwot.o and uwot.dll end up at > 32MB in size.

from uwot.

LTLA avatar LTLA commented on June 15, 2024

If major surgery on uwot's C++ code is required... maybe you might consider whether umappp might be a good place to put that effort? It might be possible to achieve the dream of consolidating all the C++ code floating around into a central library that can be re-used elsewhere (e.g., LTLA/umappp#5).

Happy to give you maintainer access, I pretty much copied uwot's code anyway, though I did strip out TBB in favor of std::thread and/or OpenMP. I don't think I used much templating either.

Anyway, just a thought, no pressure.

from uwot.

jlmelville avatar jlmelville commented on June 15, 2024

Moving over to umappp is a good idea (I also moved to only using std::thread a while ago). But I probably can't make the change for uwot without breaking backwards compatibility or adding a lot of stuff that no-one would want in umappp. So I will have to work out how to split that up.

In the current code base there are some templated things that only get called once an epoch and which can be made pointer-based, which might buy me some time.

from uwot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.