integer and numeric numeric custom fields incorrectly assumed to be monetary

[jmaconsulting]

integer and numeric numeric custom fields incorrectly assumed to be monetary

[Edzelopez]

Thanks for the suggestions @lcdservices !

I will provide a patch shortly.

[Edzelopez]

@lcdservices does this patch solve the issues you were having?

[lcdservices]

Yes, that fixes it. Though I think at some point you will want to do more cleanup.
For example, in Main.tpl you are conditioning on type = Int, which is no longer relevant.
And in Main.php you are conditioning on type = Money and changing the type to Float, which is also no longer necessary. And just prior to the affected code you set a few fixed fields as $numericFields and set them to type = Float.

So yes, this patch fixes the heart of the problem. But you could clean things up a bit to reflect the change.

[JoeMurray]

@lcdservices thanks Brian!

@Edzelopez please do a thorough code review and cleanup over the next 10 days.

@monishdeb @seamuslee001 we should discuss planning in our next scrum a thorough review and possible cleanup of our other extensions now that core is fixing up money formatting.

[Edzelopez]

Yep @lcdservices

The cleanup is intended to have it's own PR and is in progress. Thanks for the suggestions!