An improper locking bug(e.g., deadlock) on the lock psLogin->psServer->psAudit->ptmMutex

[jmk-foofus]

An improper locking bug(e.g., deadlock) on the lock psLogin->psServer->psAudit->ptmMutex

[ycaibb]

The situation is similar to the below code on the lock ptmSSLMutex, which is not released when sslContext == NULL, (hSocket < 0) && ((hSocket = medusaConnect(pParams)) < 0), (ssl = SSL_new(sslContext)) == NULL, SSL_connect(ssl) <= 0...

medusa/src/medusa-net.c

Lines 343 to 396 in bdaa2dd

	pthread_mutex_lock(&ptmSSLMutex);
	SSL_load_error_strings();
	SSLeay_add_ssl_algorithms();
	/* OpenSSL 1.1.0 introduced TLS_client_method() and deprecated all version specific functions. */
	sslContext = SSL_CTX_new(TLS_client_method());
	if (sslContext == NULL)
	{
	err = ERR_get_error();
	writeError(ERR_ERROR, "SSL: Error allocating context: %s", ERR_error_string(err, NULL));
	return -1;
	}
	// set the compatbility mode
	SSL_CTX_set_options(sslContext, SSL_OP_ALL);
	// we set the default verifiers and dont care for the results
	SSL_CTX_set_default_verify_paths(sslContext);
	SSL_CTX_set_verify(sslContext, SSL_VERIFY_NONE, NULL);
	if ((hSocket < 0) && ((hSocket = medusaConnect(pParams)) < 0))
	return -1;
	if ((ssl = SSL_new(sslContext)) == NULL)
	{
	err = ERR_get_error();
	writeError(ERR_ERROR, "Error preparing an SSL context: %s", ERR_error_string(err, NULL));
	return -1;
	}
	SSL_set_fd(ssl, hSocket);
	if (SSL_connect(ssl) <= 0)
	{
	err = ERR_get_error();
	writeError(ERR_ERROR, "Could not create an SSL session: %s", ERR_error_string(err, NULL));
	return -1;
	}
	writeError(ERR_DEBUG, "SSL negotiated cipher: %s", SSL_get_cipher(ssl));
	s = malloc(sizeof(struct SSLSOCKETINFO));
	memset(s, 0, sizeof(struct SSLSOCKETINFO));
	s->id = hSocket;
	s->nUseSSL = 1;
	s->ssl = ssl;
	s->sslContext = sslContext;
	HASH_ADD_INT( psSSLSocketInfo, id, s );
	pthread_mutex_unlock(&ptmSSLMutex);

[ycaibb]

Hi, developers @jmk-foofus

Any comments would be highly appreciated. Thank you.

Best Regards,