Giter Site home page Giter Site logo

Comments (8)

mstevetodd avatar mstevetodd commented on June 12, 2024

@adamcmain I've no issue with the request, but it's probably worthwhile to also investigate why your device is disconnecting regularly and fix it. You can contact me via email and I'll work with you on that.

@flash62au any thoughts on this request?

from enginedriver.

flash62au avatar flash62au commented on June 12, 2024

@mstevetodd @adamcmain Yes, it is easy enough to add a preference to disable it, but I agree that I would be more concerned about why it is disconnecting so often.

from enginedriver.

flash62au avatar flash62au commented on June 12, 2024

@adamcmain
I have committed the change to add a preference to disable the sound and vibrate on disconnect. #758

It should be available on the release of the next beta.

If you want to try it out now...
I have created an apk here https://drive.google.com/file/d/16estVH21vJWAG6gEV_sXDNLHsI-yBNPv/view?usp=sharing
NOTE: I can't sign it with the real keys (Steve's keys) so if you want to try it you can download and install but you will need to uninstall the real version first (export your preference before you do, and import once this version is installed.)

from enginedriver.

adamcmain avatar adamcmain commented on June 12, 2024

Hi, thanks for making the changes. Any idea when the beta will include this option?

from enginedriver.

mstevetodd avatar mstevetodd commented on June 12, 2024

Hi, thanks for making the changes. Any idea when the beta will include this option?

"Soon" :)
I have "one more change", related to LnWi, I'm trying to get into this one.
Unfortunately, DayJob and RealLife keep interfering!
It will be before the end of the year, with or without my "next" change.

from enginedriver.

Alan-RMA49 avatar Alan-RMA49 commented on June 12, 2024

I'll jump in here as I've encountered a similar problem. As the club's social media guy and an avid instagramer in my (remaining) spare time, I use my phone a lot and I have it set to lock automatically after 15 seconds to avoid using too much battery.

Whenever I'm using ED I increase the lock time to 60 seconds because I've found that whenever the phone locks, ED seems to lose the connection to JMRI and then takes a few seconds to reconnect, with the associated sound and triple vibration (ED never loses the connection while the phone is unlocked, the wifi connection is fine and at full strength). I've seen at least two collisions on the layout due to this... Adam, could this be what you're encountering?

If that's the case, Android has a permission allowing an app to disable the lock screen under certain conditions (in ED's case it would probably need to be whenever it's in focus, but probably with a warning that it'll use more battery). I think there's also a permission to maintain the network connection when the screen's locked, which might be a better solution. Having both probably be ideal for end-users.

Of course I may be barking up the wrong tree here, but it's worth investigating as the root cause of the issue.

Alan

from enginedriver.

mstevetodd avatar mstevetodd commented on June 12, 2024

Thanks, Alan.

Note that Peter's change is in the current Production version 2.27.121, released a couple of days ago. I should have updated this issue.
@adamcmain please close this issue if the new version solves the problem for you.

from enginedriver.

mstevetodd avatar mstevetodd commented on June 12, 2024

In production with no reported issues. Closing.

from enginedriver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.