Comments (4)
Actually, it looks like it fails when the two-letter-character class is the
first item in the regex.
laptop$ csearch 'd[gG]r'
/[XXXXX]/userids.txt:dgryski
Original comment by dgryski
on 24 Jan 2012 at 2:09
from codesearch.
I did a bit of investigation last night and it looks like the problem is with
match.go:stepByte(). If we need to fold for this particular instruction, we
uppercase the character 'c', but it doesn't get reset back to the lowercase
version when we move on to processing the next state -- the character 'c' is
still the modified uppercase version instead of the original lowercase version
that's actually in the string.
I've attached a patch to match.go to fix this, and two test cases to
regexp_test.go.
Original comment by dgryski
on 27 Jan 2012 at 8:51
Attachments:
from codesearch.
This issue was closed by revision 5cd8d184e954.
Original comment by dgryski
on 2 May 2012 at 8:05
- Changed state: Fixed
from codesearch.
Issue 19 has been merged into this issue.
Original comment by dgryski
on 2 May 2012 at 8:54
from codesearch.
Related Issues (20)
- Line missing in read.go HOT 3
- csearch: Add flag (-g) for grouping output by file (a'la ack --group, or git grep --heading) [PATCH] HOT 4
- Error in read.go comments
- go install fails to find package
- Option to remove a path from index
- Pull request: add support for per-file custom annotations
- "csearch -n" output is 0-based, not 1-based HOT 1
- Files containing ascii8 are not indexed (feature/request) HOT 4
- IndexWriter always writes logs
- How can I tell cindex to ignore certain folders? (such as logs/, *.log, tmp/ etc.) HOT 3
- cindex fails with mmap errors on OpenBSD HOT 1
- Cannot index / search one file HOT 8
- mmap_windows.go not updated for latest go version
- .csearchindex is world-readable HOT 1
- cindex needs vast amounts of temporary space HOT 1
- Windows missing conversion HOT 1
- fix bug in siftUp() HOT 3
- Patch for /index/write_test.go HOT 1
- cindex ignores IRC log files HOT 3
- Minor adjustment of Csearch page. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codesearch.