RollingFileOutputWriter

[zbintliff]

RollingFileOutputWriter

[cyrille-leclerc]

This looks great, thank you very much for this work that could help many users. Could you propose a pull request?

Regarding Java 6 or 7, I think we can stipulate that the RollingFileOutputWriter requires Java 7 (we would compile with Java 6 compatibility, it's just this appender that would throw a ClassNotFoundException with Java 6).

Regarding the date formatting:

• could you protect the thread safety of the SimpleDateFormat (e.g. adding synchronized to the method). Even if the implementation is currently single threaded, this may cause nasty bugs if we one day decide to multi thread.

• did you think of formatting the date with the ISO 8601 format which holds the timezone ?

  TimeZone tz = TimeZone.getTimeZone("UTC");
  DateFormat dfISO8601 = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm'Z'");
  dfISO8601.setTimeZone(tz);
  String nowAsISO8601 = dfISO8601.format(new Date());

[zbintliff]

Think its done, just need to test later.

[cyrille-leclerc]

The only non-thread safe part of SimpleDateFormat is the actual format() method right? The postConstruct() doesn't need to be synchronized right?

Correct, in our case, only simpleDateFormat.format() needs to be thread safe.

[cyrille-leclerc]

Version 1.0.7 adds RollingFileOutputWriter. It should be soon visible in Maven Central.

https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.0.7