Comments (3)
Looking through the file output writers an idea that strikes me is to write a new OutputWriter
called simply FileOutputWriter
and making it a bit more generic. This writer could support both use cases that we have in the two different writers now. Then we could also add pattern support for how the results would be written, allowing us to create a pattern that writes each collection to a single line as in your use case.
Then we could deprecate the two existing file writers and refactor them to just delegate to the new generic one with behavior kept.
Thoughts on this idea?
from jmxtrans-agent.
So would you like to see a pull request for my single line version renamed to FileOutputWriter
(which is a modification of RollingFileOutputWriter
) as a starting point for refactoring?
I would see this in line of flags:
- overwriter vs rolling
- single vs multi
Thanks
from jmxtrans-agent.
I would like to avoid adding a new file writer unless we can deprecate the old ones - otherwise we will have three to support, with a lot of duplication, and once we have added FileOutputWriter
we can't really change how it is configured without breaking backwards compability.
If you want changes merged, I suggest that you for now add a configuration flag to the RollingFileOutputWriter
to support single line logging. That does not feel too invasive.
If you want to work more on it and create a more generic FileOutputWriter
to support all cases as I outlined above it would be appreciated!
from jmxtrans-agent.
Related Issues (20)
- JBOSS (EAP 7.1.0) JMX Attributes disappear while running jmxtrans-agent HOT 11
- Disable logging for JMX trans agent HOT 4
- Multi-tag issue in StatsDOutputWriter
- Flow not working with JDK 1.6
- Add Security Manager Policy
- JMXTransAgent with a jboss/wildfly and JDK 1.9 (-Xbootclasspath gone)? HOT 5
- RollingFileOutputWriter writes additional empty line when setting 'singleLine' is true HOT 2
- Springboot application - Issue in fetching tomcat threads and datasources
- Hinders Tomcat from starting MBeans
- Help with the parameters for the constructor class Invocation HOT 4
- jmxtrans-agent.xml example with <invocations> block
- Only getting first attribute for java.lang:type=OperatingSystem HOT 1
- JMXTrans data to statsd comes multipe times HOT 2
- How do i capture springboot datasource for springboot versions before 1.5.5
- Please post JARs for lastest three releases HOT 2
- jmxtrans-agent to use in spring boot application
- numQueryThreads parameter tuning HOT 1
- Got java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip() testing the version 1.2.11-rc-2 HOT 4
- Is InfluxDbOutputWriter still considered experimental? HOT 3
- How to set log level for jmxtrans-agent HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmxtrans-agent.