Comments (9)
I think the dune subst
command modifies the working directory. Don't forget to restore the file plotkicadsch/src/plotgitsch.ml
when applying it again.
from plotkicadsch.
Short version -h
for help, ok, but -v is usually used for verbose, not version.
from plotkicadsch.
Sure, the right thing is -V
for version.
from plotkicadsch.
I would like to have this -V
or --version
working because for me it is important to check if running your original plotgitsh
version or my custom build.
I just don't know yet how to change this version number. It looks like it is opam dependent, since when I build it with makefile the version is missing.
Why?
There is one thing that it is important for kdiff
to work. Being able to save to
and from
images even if they don't have any difference.
I believe you still don't have such a feature, right?
For instance, if we have a flag that allows that, then I could end with my fork to use your repo instead which is a better option, I think since users will have your version installed and not mine.
The way I am achieving this is by removing a test where it compares if images are different before doing the visual diff.
The best thing to do would create a command-line parameter allowing this. However, I believe this test could also be removed because it is good to show to the user an image without any changes. So, this is what the user is expecting.
Well, once the comparison has no differences plotgistch
could return a value higher than 0 indicating that, if needed.
from plotkicadsch.
I would like to have this
-V
or--version
working because for me it is important to check if running your originalplotgitsh
version or my custom build.
Isn't the version working? if you type plotgitsch --version
what does it print?
from plotkicadsch.
When I install it by pinning it I see this.
➜ plotgitsch --version
%%VERSION%%
from plotkicadsch.
The substitution with the content of git describe
is only performed when calling dune subst
in the directory.
So I would recommend:
$ opam install dune
$ dune subst
$ opam pin add -y -k path kicadsch .
$ opam pin add -y -k path plotkicadsch .
$ opam install -y plotkicadsch
Let me know if it changes your version string.
from plotkicadsch.
Look promising, but I am not sure what is going on.
[NOTE] Package kicadsch is already pinned to file:///home/lheck/Dropbox/Documents/plotkicadsch_lheck (version 0.8.0-35-g00077d7-dirty).
[kicadsch.0.8.0-35-g00077d7-dirty] synchronised from file:///home/lheck/Dropbox/Documents/plotkicadsch_lheck
[WARNING] Failed checks on kicadsch package definition from source at file:///home/lheck/Dropbox/Documents/plotkicadsch_lheck:
error 3: File format error in 'version' at line 2, column 0: Duplicate field version
error 3: File format error in 'version' at line 3, column 0: Duplicate field version
kicadsch is now pinned to file:///home/lheck/Dropbox/Documents/plotkicadsch_lheck (version 0.8.0-35-g00077d7-dirty)
Already up-to-date.
Nothing to do.
from plotkicadsch.
opam pin remove
did the trick.
➜ plotgitsch --version
v0.8.0-35-g00077d7
Pretty nice, thanks.
from plotkicadsch.
Related Issues (20)
- git is changing to the master branch HOT 13
- plotgitsch command performs checkout to master HOT 2
- Running on Windows HOT 7
- Limit gitplotsch scope in nested projects HOT 20
- Do not fail when a part is missing HOT 14
- Flag for generating/keeping images even if the images do not have changes
- Commit info HOT 6
- Intermediate images do not have a transparent background HOT 6
- Exception (Invalid_argument "index out of bounds") HOT 2
- Minor details in the produced image HOT 2
- Internal error when it finds (maybe broken) symlinks HOT 18
- Keeping original files even if they don't have changes HOT 18
- Makefile - Making package
- Diffing local changes does not work when an untracked folder is into the repo HOT 9
- License type HOT 2
- Do you have a. Kicad SCH format to support KICad 6.0 HOT 3
- Plotkicadsh fails with missing components HOT 4
- plotgitsch could return 1 when at least of the commits is using the new `.kicad_sch` format
- Distro-specific issue and possible patch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plotkicadsch.