Xml not parsing properly

[jnunemaker]

Xml not parsing properly

[sr75]

I had the same issue with default xml parser. Seems the httparty default xml parser isn't a one for one implemenation of the Crack::XML.parse functionality. The crack xml parser allows you to get at attributes in the hash. The httparty parsed response doesn't, I've verified this in rspec tests because a project I'm working on requires me to parse the attributes for processing certain logic.

<root><action condition="email">threshold not met, email response</action></root>

Here's a workaround to get at xml attributes using Crack::XML.parse:

 def self.submit(submission, setting)
     Crack::XML.parse(get(setting.uri, query: build_insert_query_string(submission, setting)))
 end

 xml_doc = Wonky::Webservice.submit(submission, setting)

• using crack the xml attributes are accessible via [][] syntax
• if you don't use crack the default httparty xml parser doesn't include attributes and errors when trying to access the attribute key
• default parser only includes the content of the tags in the parsed hash

using the crack parser you would get at the attributes like so:

puts xml_doc['root']['action'].attributes
puts xml_doc['root']['action'].attributes['condition'] # condition is an attribute of action tag

So to get this working as advertised, Httparty needs some tests for the xml parsing scenarios involving attributes to make sure it's implementing the full Crack::XML.parse functionality for xml attributes.