Giter Site home page Giter Site logo

Comments (12)

edkolev avatar edkolev commented on June 2, 2024 2

I don't think it's as simple as just enabling it - there might be places in the code which rely on a dynamic (as opposed to lexical) scoping. The challenge would be to check there are no regressions after the switch.

I see this comment mentions making the switch #926 (comment)

from yasnippet.

Panadestein avatar Panadestein commented on June 2, 2024 1

There is relevant information on the Emacs mailing list. It has been suggested that it is related to refactoring macroexpand in this commit e85ebb3d82466c5838e9c6836e6d8b5c8d0a7c33

from yasnippet.

dalugm avatar dalugm commented on June 2, 2024 1

This issue seems like related to this:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64292

After add lexical-binding: t in yasnippets.el, I can use yasnippet just like before.

from yasnippet.

SjB avatar SjB commented on June 2, 2024

I'm also seeing this error. on GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-06-25 using the Melpa 20200604.246 version of yasnippets.

from yasnippet.

SjB avatar SjB commented on June 2, 2024

The error is from the yasnippet-snippets package.

from yasnippet.

Panadestein avatar Panadestein commented on June 2, 2024

@SjB how did you debug this? Did you find a workaround?

from yasnippet.

SjB avatar SjB commented on June 2, 2024

No workaround yet didn't have time.

from yasnippet.

dalugm avatar dalugm commented on June 2, 2024

The error is from the yasnippet-snippets package.

I guess not, I'm not using yasnippet-snippets and I still met this error.

And this error also happens in my config, one in borg managed, one in use-package managed.

I think it's the new version Emacs leads to this.

Using Emacs 29.0.92 works fine, but using the master branch broke.

The only problem is to figure out which commit leads this...

from yasnippet.

Panadestein avatar Panadestein commented on June 2, 2024

I haven't debugged in detail yet, but rolling back to 8806bbbf2cdae00faacab9cec634072ce4e80b6f lets me use yasnippet again.

from yasnippet.

edkolev avatar edkolev commented on June 2, 2024

Adding lexical-binding: t in yasnippets.el mitigates the issue for me as well. However, I can't help but wonder what it breaks in yasnippet :)

from yasnippet.

Panadestein avatar Panadestein commented on June 2, 2024

Shall we make a pull request adding it?

from yasnippet.

Panadestein avatar Panadestein commented on June 2, 2024

As discussed in the emacs-devel mailing list, the issue got solved in dcd92090950929eeea3040fcac0294b7a4d839f0.

from yasnippet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.