Comments (5)
And the radius result is wrong too, I sampled on a "white" part of an image and it is reading it as rgb(164, 159, 140).
<EyeDropper pickRadius={{ unit: 'radius', amount: 1 }} />
Setting amount to 0 gives a blow up number.
from react-eyedrop.
Uh-oh. Smells like a bug in the dependencies. Will have to change the way pixels are translated into colors.
Setting amount to 0 with unit radius should be handled with an error. That's a bug, right there.
from react-eyedrop.
Setting amount to less than 1 now correctly throws an error.
The dependency bug will be handled as soon as a better replacement is found.
from react-eyedrop.
Saw that the canvas-to-color dependency had a major update which contained a bugfix.
Updated the dependency and released version 3.3.2 containing the update.
Let's see if this resolved the issue.
from react-eyedrop.
Nope, all the color are still wrong :(
from react-eyedrop.
Related Issues (20)
- default styling overrides buttonClasses styles HOT 3
- Option to define a radius when sampling color? HOT 7
- Color selection is offset HOT 7
- Getting an error for Unsupported image type HOT 2
- Example not working + errors in my own implementation HOT 9
- Invalid Hook Call HOT 21
- Uncaught TypeError: html2canvas_1.default is not a function HOT 5
- How can I tell when the component exits the picking state? HOT 4
- Allowing inline styling on the Eyedropper component? HOT 7
- Eyedrop does not work on background image HOT 4
- backgroundImage check HOT 2
- support compatibility with React 18 HOT 6
- reset cursor to default on unmounting HOT 2
- Usage examples HOT 2
- onPickStart, onPickEnd for hook HOT 4
- No way to remove listener when using once={false} HOT 6
- Using in webview always return white as the color HOT 1
- Can't change button text to empty HOT 7
- Excessive looping on customComponent when populating eyedropper buttons using map HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-eyedrop.