Giter Site home page Giter Site logo

Comments (5)

gundamftw avatar gundamftw commented on August 9, 2024 1

And the radius result is wrong too, I sampled on a "white" part of an image and it is reading it as rgb(164, 159, 140).

<EyeDropper pickRadius={{ unit: 'radius', amount: 1 }}	/>

Setting amount to 0 gives a blow up number.

from react-eyedrop.

jodhman avatar jodhman commented on August 9, 2024

Uh-oh. Smells like a bug in the dependencies. Will have to change the way pixels are translated into colors.

Setting amount to 0 with unit radius should be handled with an error. That's a bug, right there.

from react-eyedrop.

jodhman avatar jodhman commented on August 9, 2024

Setting amount to less than 1 now correctly throws an error.
The dependency bug will be handled as soon as a better replacement is found.

from react-eyedrop.

jodhman avatar jodhman commented on August 9, 2024

Saw that the canvas-to-color dependency had a major update which contained a bugfix.
Updated the dependency and released version 3.3.2 containing the update.
Let's see if this resolved the issue.

from react-eyedrop.

gundamftw avatar gundamftw commented on August 9, 2024

Nope, all the color are still wrong :(

from react-eyedrop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.