Giter Site home page Giter Site logo

Comments (11)

qortex avatar qortex commented on May 30, 2024

It also introduces quite a bit of bad-rendered icons:
image

Maybe we should have a switch to choose which emoji release version we want to stick with, letting time for a vast majority of the userbase to have the new fonts?

from picmo.

joeattardi avatar joeattardi commented on May 30, 2024

from picmo.

qortex avatar qortex commented on May 30, 2024

Ok great, thanks!

Any idea on how to have all emojis supported for everybody? I can't make total sense of what I read and I'm sure you are very knowledgeable about all that :)

from picmo.

joeattardi avatar joeattardi commented on May 30, 2024

The OS system fonts have to be updated to support the new emojis. Emojis are a sequence of Unicode code points. For example, the Pilot emoji is a sequence of the Adult emoji and the Airplane emoji, joined by a Unicode Zero Width Joiner character. If, for example, the OS did not recognize this sequence for the Pilot emoji, it would show an Adult emoji next to an AIrplane emoji.

Unfortunately there is no fix other than updating the operating system.

from picmo.

qortex avatar qortex commented on May 30, 2024

Ok thanks for the explanation.

Then, I guess a config parameter would be the best option for the emoji set, no?

Because if you release a new breaking change version 3.0.0, it means that a project that sticks with the previous emoji set won't get the future updates / fixes on version 2.x.x - and so on with next emoji updates.

What do you think?

from picmo.

joeattardi avatar joeattardi commented on May 30, 2024

I like the idea, but that's a tricky one - I am not sure how I would support that. The emoji-datasource package does not specify the version of Unicode each emoji is from. So there'd be no way to choose between different versions.

Within reason, I would support the 2.x.x line with features and bug fixes, at least for a while until it's more likely that people will have the newer emoji support.

I could also look around and see if there's another emoji library that would have the version information. Let me do that and see what's out there.

Thanks for the suggestions!

from picmo.

qortex avatar qortex commented on May 30, 2024

Great! Thanks.

Following the status of those releases might be one of many indicators about wide adoption -- although I don't really know what coverage it might represent.

from picmo.

joeattardi avatar joeattardi commented on May 30, 2024

Actually, it turns out that emoji-datasource includes the version each emoji was added. So I could most likely add a version option to specify the Emoji version to use!

from picmo.

joeattardi avatar joeattardi commented on May 30, 2024

I have just released v2.7.0 which includes an emojiVersion option.

from picmo.

qortex avatar qortex commented on May 30, 2024

Awesome, thanks!

from picmo.

qortex avatar qortex commented on May 30, 2024

Actually, still have the blank column. I guess that's because I miss a glyph in the "flags" section?

See:

image

from picmo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.