Python 3 support

[joerick]

Python 3 support

[joerick]

Hi @asmeurer,

I don't use Python 3 myself yet on any of my projects, but I'm keen to see it succeed so I'd like to support Python 3 if we can. I don't much like the 2to3 approach i.e. maintaining two codebases or having one generated from the other, so I'm more inclined to look six. If I can avoid including that, though, I will, since it's a pretty small project it might not need it.

After a quick look I can see the following things:

• use of iteritems in profiler.py:123
• use of exec in main.py:41
• possibly some string/byte confusion with the ANSI colors

so hopefully it'll be fairly straightforward.

[asmeurer]

Yes, I think writing a compatible code-base without 2to3 or six in your case will be pretty easy. I would recommend not supporting Python 3.2, so that you can keep the unicode literals.

I ran the code through 2to3 and successfully used it, so that means that there shouldn't be many issues aside from the ones that it picks up. So I would just run 2to3 and then go through the diff and fix things to be cross compatible rather than Python 3-only compatible.

[asmeurer]

Here is what the 2to3 result looks like https://github.com/asmeurer/pyinstrument/compare/2to3?expand=1. I'll probably just do the whole port right now. This tool has helped me a lot today. I think you deserve it.

[asmeurer]

By the way, you totally had a typo. except SystemExit, KeyboardInterrupt uses KeyboardInterrupt as the name for the caught SystemExit exception. You want except (SystemExit, KeyboardInterrupt). Fortunately, Python 3 disallows this mistake.