Comments (2)
This is still a problem, e.g.:
a <- yr(10, "BC")
b <- yr(10, "CE")
b - yr_transform(a, "CE")
#> # CE years <yr[1]>:
#> [1] 20
#> # Era: Common Era (CE): Gregorian years (365.2425 days), counted forwards from 0
Redefining era epochs using an epoch that has a year 0 (e.g. b2k) might help?
from era.
Redefining epochs in a system without a year 0 is a good solution, but b2k introduces the complication of it now being counted backwards instead of forwards. So instead we'll stick with Gregorian years, but using astronomical numbering, i.e. there is a year zero.
This means the epoch of CE is now 0 (i.e. the start of 1 CE was one year after the start of 0 CE) and the epoch of BCE is now 1 (i.e. the start of 1 BCE was one year before the start of 1 CE). Definitions of epochs derived from a (fractional) CE year, e.g. Hijri years, also had to be adjusted.
This seems to make things consistent across the board. I've also added a test to try and catch these annoying off-by-one issues in era definition in future.
from era.
Related Issues (20)
- Test coverage HOT 1
- Add precision argument to yr_transform()
- era arguments should always accept a character label
- Conversion between year units HOT 2
- Use rlang error handling
- Inconsistent warnings when combining eras with different labels/names HOT 1
- More informative error message for era("unknown era") HOT 1
- Conversion between eras with NA units
- Release era 0.3.1 HOT 2
- Method for strictly comparing eras HOT 1
- Pillar printing for era HOT 1
- Pillar printing for era_year HOT 1
- Year to date conversions
- NetCDF compatability
- Switch to native pipe HOT 1
- Cast character to era_yr?
- Add CONTRIBUTING
- Release era 0.4.0
- CRAN checks failed
- Release era 0.4.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from era.