Giter Site home page Giter Site logo

Comments (8)

johanvanhelden avatar johanvanhelden commented on July 25, 2024 1

Great to hear you like the action.

If you would be able to PR the modification, I'd really appreciate it! Thanks!

from gha-clover-test-coverage-check.

johanvanhelden avatar johanvanhelden commented on July 25, 2024 1

The fix has been released, thanks @jospapePAQT !

from gha-clover-test-coverage-check.

pfy-oleksii-storozhylov avatar pfy-oleksii-storozhylov commented on July 25, 2024 1

No warnings anymore, but I have empty value while trying to access coverage and other values

${{ steps.coverage.outputs.coverage }}

from gha-clover-test-coverage-check.

jospapePAQT avatar jospapePAQT commented on July 25, 2024 1

No warnings anymore, but I have empty value while trying to access coverage and other values

${{ steps.coverage.outputs.coverage }}

it is now stored in $GITHUB_OUTPUT

echo "${{ env.steps.coverage.outputs.coverage }}" # This will output the coverage

from gha-clover-test-coverage-check.

jospapePAQT avatar jospapePAQT commented on July 25, 2024

UP

from gha-clover-test-coverage-check.

greatislander avatar greatislander commented on July 25, 2024

No warnings anymore, but I have empty value while trying to access coverage and other values

${{ steps.coverage.outputs.coverage }}

it is now stored in $GITHUB_OUTPUT

echo "${{ env.steps.coverage.outputs.coverage }}" # This will output the coverage

The README is not up to date anymore.

from gha-clover-test-coverage-check.

pfy-oleksii-storozhylov avatar pfy-oleksii-storozhylov commented on July 25, 2024

No warnings anymore, but I have empty value while trying to access coverage and other values

${{ steps.coverage.outputs.coverage }}

it is now stored in $GITHUB_OUTPUT

echo "${{ env.steps.coverage.outputs.coverage }}" # This will output the coverage

It doesn't work for me as well :(
Also in docs I found that env. should not be used for getting output step value https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-3
But the weird thing they propose to use (and it works for me)

echo "SELECTED_COLOR=green" >> $GITHUB_OUTPUT

But in action logs I see output with ## symbols:

##"coverage=99.438202247191" >> $GITHUB_OUTPUT

from gha-clover-test-coverage-check.

johanvanhelden avatar johanvanhelden commented on July 25, 2024

@pfy-oleksii-storozhylov @greatislander @jospapePAQT

Apologies for the late response. Due to personal reasons I was unable to work on this sooner.

I have now pushed the fixes to the action in #13.

The README on how to use the output remains correct. It was simply a faulty implementation of setting the output in #11

So any new runs of the workflow should show proper output again, as you can see here:
https://github.com/johanvanhelden/gha-clover-test-coverage-check/actions/runs/3558639385/jobs/5977451791

image

from gha-clover-test-coverage-check.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.