Holes: modelling threads changes position

[johk]

Holes: modelling threads changes position

[DougCollinge]

Relevant code in hole_threaded:
translate([0,0,-l/2])
if (thread=="modeled") {
thread(orad, l, lead);
} else {
cylinder(r=irad+cltd/2,h=l,center=true);
}

I presume that the problem is with "center=true".

[JohK]

Thanks for spotting the bug. Actually the thread is displaced, I currently can't put much time into my 3d printing hobby and havent worked with or on the lib for quite a while. I hope I didn't make matters worse with my "fix"... :)

BTW: The intention of the library is to use the penetrated surface as the reference. (aka where would the hole start, or where would the screw head mate with the part...)

[DougCollinge]

Thanks! I agree that the surface is the right reference and that's why I thought the behaviour of the hole with modeled threads was weird. I doubt if this is going to cause a problem for anyone because everyone probably uses the threaded hole without the threads modeled. I only noticed it because I was just trying it out to see what it looks like.