Stuck loading IMAP message

[stanio]

Stuck loading IMAP message

[stanio]

Looking into it a bit further – the problem happens just with the latest MessageFaces 1.3, and doesn't happen with version 1.2.6 (changes).

[JohnDDuncanIII]

Sorry I missed this, it seems like quite a nasty bug. Let me take a look this weekend and get back to you!

[JohnDDuncanIII]

@stanio I believe that I've figured this out.

var inputStream = new (
	Components.Constructor(
		"@mozilla.org/scriptableinputstream;1",
		Components.interfaces.nsIScriptableInputStream
	)
);
inputStream.init(messageStream);

var content = "";
inputStream.available();
while (inputStream.available()) {

in chrome/content/headerOverlay.js fires before the imap message can complete its download, which means that the XPCOM call leads to lock contention/deadlock on the network thread responsible for completing the imap message download.

I took the advice outlined here and added

document.getElementById("messagepanebox").addEventListener(
	"load",
	function messagePaneLoader(e) {
		mfO_UpdateMessageHeaders();
		mfDisplayFace();
	},
	true
);

which fixes the problem.

---

It also looks like mailcheck.js broke due to http://mozilla.6506.n7.nabble.com/Upcoming-change-to-fixIterator-function-in-iteratorUtils-jsm-td367711.html (dead link — see https://groups.google.com/g/tb-planning/c/lbQIuLNv_2s), so I've fixed that as well.

I will draft a release and let you know when it's ready for download.

As an aside, I have recently moved back to the Firefox/SeaMonkey/Mozilla platform and plan on cleaning this project up a bit as I wrote this when I was initially learning javascript/html/css/xul back in college. Now that I have almost three years of professional experience, I have made a list of infrastructural and stylistic improvements that I would like to add to this project.

[JohnDDuncanIII]

@stanio

https://github.com/JohnDDuncanIII/messagefaces/releases
https://github.com/JohnDDuncanIII/messagefaces/releases/download/1.3.1/messagefaces-1.3.1.xpi

http://cs.gettysburg.edu/~duncjo01/sites/messagefaces/
http://cs.gettysburg.edu/~duncjo01/sites/messagefaces/download/messagefaces1_3_1.xpi
http://cs.gettysburg.edu/~duncjo01/sites/messagefaces/history.html