Crashes on webpack 4.x

[johnnyreilly]

Crashes on webpack 4.x

[developer-lindner]

Works with alpha version, but the order seems to be crucial:

new ForkTsCheckerWebpackPlugin(),
new ForkTsCheckerNotifierWebpackPlugin(),

[johnnyreilly]

Hey @eramdam, thanks for the test! I've published a new release of the fork-ts-checker-webpack-plugin on the unofficial alpha channel: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin which people can use until fork-ts-checker-webpack-plugin ships next time.

I'll leave this issue open as an aide memoire in the mean time.

[johnnyreilly]

Cool - that may be a requirement of the new webpack plugin approach. Would you like to submit a docs PR stating that so others don't get stuck on this?

[johnnyreilly]

Yup - I think that this fix is required in fork-ts-checker-webpack-plugin: TypeStrong/fork-ts-checker-webpack-plugin#104

This has been merged but not yet shipped. Do you want to clone fork-ts-checker-webpack-plugin, build it and test it to confirm if that's correct?

If so then I might put out a release of the fork-ts-checker-webpack-plugin on the unofficial alpha channel: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin

[eramdam]

@johnnyreilly it works. I used yarn link to use a local built version of fork-ts-checker-webpack-plugin to test and the notifications work 👍

[developer-lindner]

@johnnyreilly with tslint: true in configuration of ForkTsCheckerWebpackPlugin any notification will be disabled?! sad :/

[johnnyreilly]

In what way? Notification doesn't happen if tslint is in play? Could you sling some console.logs in your local build and discover if it's not being handled correctly upon receipt or whether it's not arriving at all? I'd really appreciate it if you could put some time into this. My new application is going live right now so I'm fairly occupied... Happy to advise though!