How does the delete mutation works if the action commit the id instead of the full hero object ?

[johnpapa]

How does the delete mutation works if the action commit the id instead of the full hero object ?

[johnpapa]

Nice catch. There are a few things at work here.

1 - The action deletes the hero in the data source. Then it passes the hero id to the mutation, which then tries to find that hero to delete it from the store (this fails to find one and moves along). Then the component re-loads the heroes in the store by querying the data source. This is why it "seems" to work and I missed this originally. The net result is the same, but it is misleading, and this is why you were confused on closer inspection of the code. Nice catch!

2 - The component does not need to reload the heroes. I added this code because despite the delete of the hero in the store (which wasnt happening, but should have been) ,there is a chance that another user modifies the database and this reload will get any changes. I added a comment to clarify this in the code as I do think it's a good practice. 9d1b333

3 - The fix I implemented is to pass the hero object from the action to the mutation. This is also in this commit 9d1b333

Thanks for the raising this!

[kRapaille]

I'm glad I wasn't crazy :) I, indeed, missed the reload in the method. It explains a lot.

Thank you !