.version.txt not found when script is linked

[jomo]

.version.txt not found when script is linked

[jomo]

Well the "spacing error" is caused by the bug itself.

[jomo]

I changed the way i figure the source directory, tested on Ubuntu and OS X.
It should be working now 👍

[jomo]

@Brottweiler can you confirm it's working now?

[Brottweiler]

It's working! But first I just downloaded the script itself, and it did not seem to work. Then I cloned the repo so I got the .versions.txt file in the same directory, then it worked. Have you tried just downloading and running the script itself? Does it manage to check the remote .version.txt?

[jomo]

Hmm perhaps it would be a good idea to check if the file was found. if not, give a warning and fallback to empty string.

[Brottweiler]

In the code you can see that it runs curl -f on the remote .version.txt file, but if the file does not exist locally it will still result in that error that .version.txt cannot be found, becuase it compares the remote .version.txt with the local version of the file.
So if you only download the script, you won't have the .version.txt file.

One idea would be to have the version number in the script itself, as a variable, instead of a separate file. Then when you run it, and have the update checker enabled, it would compare that variable with the remote .version.txt file and see if they are the same.

If they are not the same, or remote version (.version.txt) is newer than local version (variable), it would tell you there's an update.
Because the variable version in the script will always be the same until you update the script by re-downloading it, and when you done that you have the new version in the script.

I am unable to test where I am currently, but would you not just be able to remove #L123 and #L124, then (for simplicitys sake) add

current_version="1.2.2"

to line #L22 or something?

[jomo]

Yea, I'll put that in a variable in the next release ;)

[jomo]

I'd need to download the whole file each time and do some extra parsing, don't like that too much.
Will probably put it at the top of the script.

[jomo]

Better idea: I store the version in a variable in the file. The version is written to file if not found or the file doesn't match with the variable. That way I can use the file on github to compare.

[Brottweiler]

Was that not what I suggested? O.o