Only load for IE 9-11?

[jonathantneal]

Only load for IE 9-11?

[mathieuhays]

@rachelnabors you could load the script dynamically with JS using the same test as svg4everybody.

<script type='text/javascript'>
(function(d,s,p){
    if(/Trident\/[567]\b/.test(navigator.userAgent)||(navigator.userAgent.match(/AppleWebKit\/(\d+)/)||[])[1]<537){
        var _s=d.createElement(s),
            _r=d.getElementsByTagName(s)[0];

        _s.async=1;
        _s.src=p;

        _r.parentNode.insertBefore(_s,_r);
    }
})(document,'script','your-path/svg4everybody.min.js');
</script>

I didn't test the code in IE but if you inline it in your html it should do the trick.

The script already checks the browser for that, so there is no need to load it conditionally.

The problem is that it cannot detect all the affected browsers, and depending on the user agent is highly unreliable anyway.

[rachelnabors]

Hmm, I was trying to reduce an HTTP request for browsers that don't need
this.

On Thu, Apr 9, 2015 at 1:49 PM János Erdei-Csóka [email protected]
wrote:

The script already checks the browser for that, so there is no need to
load it conditionally.

The problem is that it cannot detect all the affected browsers, and
depending on the user agent is highly unreliable anyway.

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

That's great but I don't think you should rely on svg4everybody, unless you change it to always inline your SVG content.

If you use SVG for icons you are much better off with Grunticon or any other solution that embeds the SVG in CSS. Which by the way is even better if your goal is to reduce the number of HTTP requests.

[rachelnabors]

It's an interactive piece, and for that reason, a number of SVGs must be
physically present on the page.
On Thu, Apr 9, 2015 at 2:11 PM János Erdei-Csóka [email protected]
wrote:

That's great but I don't think you should rely on svg4everybody, unless
you change it to always inline your SVG content.

If you use SVG to display icons you are much better off with grunticon
https://github.com/filamentgroup/Grunticon or any other solution that
embeds the SVG in CSS. Which by the way is even better if your goal is
reducing the number of HTTP requests.

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

[jonathantneal]

@Vorzard, same question about SVGs in a sprite map. Can you style them via CSS with grunticon? I think the target of grunticon is different. They're both awesome, but just target different scenarios. This project is more about using SVG capabilities than just loading vectors as images.

[deantpt]

Wouldn't it be better to use moderniser to do the checking for capabilities ?

On 9 Apr 2015, at 23:08, Jonathan Neal [email protected] wrote:

@Vorzard, same question about SVGs in a sprite map. Can you style them via CSS with grunticon? I think the target of grunticon is different. They're both awesome, but just target different scenarios. This project is more about using SVG capabilities than just loading vectors as images.

—
Reply to this email directly or view it on GitHub.

[rachelnabors]

I took a look at modernizr, but it doesn't have a way to check for ,
nor does it sniff browser versions.

On Thu, Apr 9, 2015 at 3:34 PM deantpt [email protected] wrote:

Wouldn't it be better to use moderniser to do the checking for
capabilities ?

On 9 Apr 2015, at 23:08, Jonathan Neal [email protected] wrote:

@Vorzard, same question about SVGs in a sprite map. Can you style them
via CSS with grunticon? I think the target of grunticon is different.
They're both awesome, but just target different scenarios. This project is
more about using SVG capabilities than just loading vectors as images.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

@rachelnabors

If you use svg4everybody as it is currently only a couple of WebKit browsers wouldn't work, such as Safari 7.0, and some of those less popular smartphone browsers. The problem is that future Internet Explorers will require intervention. The bigger problem is that under some network conditions svg4everybody would not be able to rely on the user agent.

Grunticon also has the same capability as svg4everybody, but for an interactive content it wouldn't be any better.

[fvsch]

@Vorzard Do you know of specific svg4everybody bugs with Safari 7? I remember it working fine in my tests. Also the script has UA sniffing for versions below 7 (AppleWebKit < 537).

@fvsch See #39.

[jonathantneal]

With Edge holding out, conditional comments is simply not the way to conditionally load this script. You would unfortunately be better off using a loader and perhaps combining that with a list of user agent sniffs.