Giter Site home page Giter Site logo

Comments (5)

silvenon avatar silvenon commented on August 18, 2024

I would also love if this was fixed. Sounds like an issue I'm having as well.

I don't think there's a scenario where you wouldn't want to name your SVG file with the .svg extension.

from svg4everybody.

jonathantneal avatar jonathantneal commented on August 18, 2024

A PR is welcome for this. Iā€™m not certain how your solution works.

from svg4everybody.

travstone avatar travstone commented on August 18, 2024

Great! have added a PR (#66), and added a bit more about what the solution does there.

My first PR on GitHub, so please do let me know if I've done anything the wrong way. Many thanks!

from svg4everybody.

jonathantneal avatar jonathantneal commented on August 18, 2024

It was an excellent PR. While Iā€™m handling this a different way, you deserve the credit. https://github.com/jonathantneal/svg4everybody/blob/feature/2.0.0/CONTRIBUTORS.md

from svg4everybody.

jaav avatar jaav commented on August 18, 2024

Hi Jonathan,
I've implemented my code as explained in the README and added a blank validator to the svg4everybody constructor (see screenshot). Then I've put a breakpoint in the JS console to check how exactly I could use this validator but it seems that this method is never hit when running my page. Any idea what I'm doing wrong?
Thanks a lot.
Grtz,
Jef

html_code
js_code

from svg4everybody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.