Giter Site home page Giter Site logo

Broken in Edge about svg4everybody HOT 13 CLOSED

jonathantneal avatar jonathantneal commented on August 18, 2024
Broken in Edge

from svg4everybody.

Comments (13)

JamesJosephFinn avatar JamesJosephFinn commented on August 18, 2024

I, too, can replicate this issue. We upgraded our Windows machine today to Windows 10, and our svg-sprites are broken in Edge.

We're using v1.0.0 – (I didn't even know this project upgraded to 2.0)

from svg4everybody.

liamness avatar liamness commented on August 18, 2024

The UA string in the VM is just

Mozilla/5.0 (Windows NT 10.0; Win64; x64)

Which means the regex test will fail, it looks for the string Edge/12 which obviously it does not find. 2.0.0 does work in a real version of Windows 10 with Edge, I guess the VM build is just out of date.

from svg4everybody.

liamness avatar liamness commented on August 18, 2024

<use> is in the latest preview now:

https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6263916-svg-external-content

from svg4everybody.

JamesJosephFinn avatar JamesJosephFinn commented on August 18, 2024

Upgrading to 2.0 worked for us. Based on our tests, this issue can probably be closed.

from svg4everybody.

bdelaney avatar bdelaney commented on August 18, 2024

hmm, insider preview win10, build 10532 and Edge does not show my SVG sprites. I'm using latest build of SVGforeverybody, 2.0 and doing images with <use>
Will download new insider preview today, build 10547, and see if it works now.
...
Aha! New version of Edge, 21.10547.0.0 works!

from svg4everybody.

jdalton avatar jdalton commented on August 18, 2024

Edge now supports SVG external content.

from svg4everybody.

srife avatar srife commented on August 18, 2024

Insider build 14267.rs1_release.160213.0213
with Edge version 31.14267.1000.0 and EdgeHTML version 14.14267
does not work.

from svg4everybody.

jonathantneal avatar jonathantneal commented on August 18, 2024

@srife, is does not work as in the polyfill unnecessarily applies or that it does not apply and external content is not working?

from svg4everybody.

srife avatar srife commented on August 18, 2024

Good question... I was having a problem with WakaTime, which apparently uses this project to display graphs. The graphs on their website were not displaying properly, so I sent a message to WakaTime. After chatting with Alan at Wakatime he pointed out this page and said he was using this to display the graphs.

I've attached an image of what one of the graphs looks like.

image

Other than that, I'm kind of clueless. I hope this is enough info to let you sort things out.

from svg4everybody.

alanhamlett avatar alanhamlett commented on August 18, 2024

Currently we removed svg4everybody since it wasn't working, in case someone is checking the production WakaTime website.

Those labels are svg text elements, so it looks like Edge is partially rendering SVG?

from svg4everybody.

jonathantneal avatar jonathantneal commented on August 18, 2024

@alanhamlett, I’m still looking for details of the issue. Is svg4everybody causing a problem? Is Edge 13 not rendering an external SVG? If you’ve removed svg4everybody, does this mean you are not using external svgs with <use> or that your site no longer works for older Edge and IE9-11 users?

from svg4everybody.

alanhamlett avatar alanhamlett commented on August 18, 2024

The svgs are not external, they are added to the dom from JS using c3. After rendered I was executing svg4everybody() but nothing changed in the svg.

Is Edge 13 not rendering an external SVG?

Not sure, because these SVGs were never using external content with <use>. I was mistaken when I thought svg4everybody helps render any svg content not just external.

If you’ve removed svg4everybody, does this mean you are not using external svgs with or that your site no longer works for older Edge and IE9-11 users?

The site works for IE9-11 without svg4everybody because we aren't using external svg elements.

This looks like the wrong use-case for svg4everybody since I'm not using external svg elements. It's just a bug in Edge with rendering normal svg.

from svg4everybody.

jonathantneal avatar jonathantneal commented on August 18, 2024

👍

from svg4everybody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.