add alpha animation for menu month view

[jonathantribouharet]

add alpha animation for menu month view

[jonathantribouharet]

From my experience, kvo is not a good thing to use in many case. In your code, it's even worse because the observer is the object itself. It's a ScrollView, you could just override layoutSubviews.
Still, this feature is not part of this library, it's like you add a code for have rounded border, it doesn't require to be in he library for work.

[yuriferretti]

Hi @f33chobits I used this code and its crashing on deallocation because the KVO observers added to observe contentOffset property aren't deallocated correctly. I saw that your code correctly remove the observers on dealloc methods but the object observed is nil on dealloc call, leading to removeObserver:forKeyPath not being executed.

[WenchaoD]

Hey @yuriferretti .
Sorry I forgot to submit my fixing to this. This problem would come up because the menuView would call dealloc ahead of menuMonthView (parent view first). So I fixed this by enumerating and removing observers in menuView. But that shouldn't be right. I think I should use NSNotificationCenter instead, which would decouple the dependence bettween menuView and menuMonthView. What do you think about this?

[WenchaoD]

#52 implement a better way. The menuView only has one observer this time.

[jonathantribouharet]

Sorry, but i cannot accept this pull request for 2 reasons:

• first, you can just add a view over the JTCalendarMenuView which can reproduce the same effect, it will be cleaner and simpler
• i will never accept a code with a try catch

[WenchaoD]

Try catch is indeed a bad solution, but is there another way to check whether there is an kvo observer yet?

[WenchaoD]

layoutSubviews is great! Thanks 👍

[yuriferretti]

@f33chobits I just moved your KVO observing code to JTCalendarMenuView's private method configureConstraintsForSubviews as @jonathantribouharet mentioned and it's working like a charm!!

[WenchaoD]

👍