Giter Site home page Giter Site logo

rename "data" generic? about rcompadre HOT 3 CLOSED

levisc8 avatar levisc8 commented on July 30, 2024
rename "data" generic?

from rcompadre.

Comments (3)

iainmstott avatar iainmstott commented on July 30, 2024

I noticed this once I'd sent the pull request, and I agree... I think actually I favour getting rid of it altogether: originally I put it in to give access to the data slot, but as I mentioned in #32, it's not actually necessary that users access that entire data.frame rather than just either the matrices or the metadata

from rcompadre.

patrickbarks avatar patrickbarks commented on July 30, 2024

I really liked data and version for the slot names. They're short and simple and don't require any thought about case style (compadreData or CompadreData?), which is nice when I want to access the slots directly. And other packages use a slot called data for metadata-type data frames, so there's some standardization.

Anyone opposed to me reverting the slot names to data and version, which will be accessible with the accessors CompadreData() and CompadreVersion(), respectively? I think it's fine if the slot names don't exactly match the accessor names. They'd still be very similar, of course.

from rcompadre.

patrickbarks avatar patrickbarks commented on July 30, 2024

closed by #43

from rcompadre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.