`wrong number of arguments (given 0, expected 1..2)` when `can_push?` called `push` (should be `pusher`?)

[jonhue]

`wrong number of arguments (given 0, expected 1..2)` when `can_push?` called `push` (should be `pusher`?)

[TylerRick]

I totally understand not having enough time! It would take a fair bit to get up to full test coverage... but you have to start somewhere. Maybe we could just add tests for any new code that's added or any code that's changed, and gradually increase the test coverage that way. I've seen that approach work pretty well before.

I'd be happy to become a collaborator, though I can't promise I'll have much more time to work on this in the near future.

Yeah, the pusher API seems pretty intuitive and fun to use. Just the settings API needs to be made friendlier.

[jonhue]

I fully agree with most that you said. I don't think that anyone had actually ever used the settings part of this gem. I initially built this gem for a project I then stopped working on soon after.
But I am still using handler & pusher in some of my other projects, so I am fairly confident that they work fine (as much as you can be confident without having some automated tests). So yeah, the documentation (at least for some components) is merely a reference to how things should work.

The thing is, that writing automated tests for a project of this size is very time consuming. Even when you do it separately for every sub-component. And, quite frankly, I don't have the time right now with work, uni, and other projects going on.

I still think that this gem provides a good basis for handling notifications, and in case of pusher also a very unique and fun way of integrating other services. So, if you're interested, I could make you a collaborator on this project, so that you can take it a step further. I would love to join you when I can free up some time.

[jonhue]

Also I agree that the settings gem needs a thorough overhaul to be actually useful.

[jonhue]

👍 for gradually adding tests with future pull requests.