Comments (4)
I totally understand not having enough time! It would take a fair bit to get up to full test coverage... but you have to start somewhere. Maybe we could just add tests for any new code that's added or any code that's changed, and gradually increase the test coverage that way. I've seen that approach work pretty well before.
I'd be happy to become a collaborator, though I can't promise I'll have much more time to work on this in the near future.
Yeah, the pusher API seems pretty intuitive and fun to use. Just the settings API needs to be made friendlier.
from notifications-rails.
I fully agree with most that you said. I don't think that anyone had actually ever used the settings
part of this gem. I initially built this gem for a project I then stopped working on soon after.
But I am still using handler & pusher in some of my other projects, so I am fairly confident that they work fine (as much as you can be confident without having some automated tests). So yeah, the documentation (at least for some components) is merely a reference to how things should work.
The thing is, that writing automated tests for a project of this size is very time consuming. Even when you do it separately for every sub-component. And, quite frankly, I don't have the time right now with work, uni, and other projects going on.
I still think that this gem provides a good basis for handling notifications, and in case of pusher also a very unique and fun way of integrating other services. So, if you're interested, I could make you a collaborator on this project, so that you can take it a step further. I would love to join you when I can free up some time.
from notifications-rails.
Also I agree that the settings gem needs a thorough overhaul to be actually useful.
from notifications-rails.
from notifications-rails.
Related Issues (20)
- Publish nested packages to this repo
- Release 3.0.1
- Release 3.0.2
- Remove badges from readme
- Fix rubocop offenses
- Enable CI for pull requests from forked repositories
- Notification Settings Category having issues comparing string to symbol on validate HOT 6
- undefined local variable or method `notification_target' for User HOT 2
- Setup dependabot
- Remove auto merge
- Update readme
- Add CodeQL
- Add issue templates
- Add pull request template
- Add security policy
- Add contributing guidelines
- Release 3.0.3
- Stop publishing to GPR
- LoadError: cannot load such file -- notification-handler HOT 5
- Test on Ruby 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notifications-rails.