Swappable pushers (separate pusher name/key from pusher class)

[jonhue]

Swappable pushers (separate pusher name/key from pusher class)

[jonhue]

Sounds good.

[TylerRick]

Something like this perhaps?

config.define_pusher :email: :ActionMailer, from: '[email protected]'
config.define_pusher :email: :SimpleMailer, from: '[email protected]'

config.define_pusher :push, :OneSignal, app_id: '...'

config.define_pusher :sms, :SMSEasy, app_id: '...'
config.define_pusher :sms, :TwilioSMS, app_id: '...'

config.define_pusher :fax, :DoPeopleStillUseFaxes, from: '123457890'
config.define_pusher :voicemail, :SomeTextToSpeechAutomatedDialerThing
config.define_pusher :carrier_pigeon, :PigeonGram
config.define_pusher :smoke_signal, :SmokeSignalsDotCom

(the names being service-agnostic names corresponding to different ways users could choose to receive notifications)

    def define_pusher(name, klass, options = {})
      pushers[name] = ::NotificationPusher::Pusher.new(klass, options)
    end

klass could be a constant symbol like the current API (would check for it under NotificationPusher:: first but still work for fully qualified constant name) or an actual constant.

Looks like this would be a breaking change...

Speaking of breaking changes, do you like the name Pusher? I think it's pretty good, but when you start talking about a "push" Pusher, it starts to sound a little bit silly/confusing. Just something to think about...

What about calling them DeliveryMethods? You can deliver notifications by email, SMS, push, etc. But is it accurate to say you push notifications via any option you can imagine? It's also what ActionMailer calls its option, not that we have to copy them.

[jonhue]

I think we can go with that. I also like the idea of renaming Pusher to DeliveryMethod. As far as I can see, this change wouldn't even require the 'pushers' itself to change. They only depend on NotificationPusher.