Comments (9)
Should be fix with https://github.com/JonnyBGod/ngx-scrollspy/releases/tag/v1.2.1
from ngx-scrollspy.
Hi guys, it has been a month so far. Will someone be looking into this soon? Please let us know.
from ngx-scrollspy.
Will someone approve my PR and complete it if I do the work? Do I need special authorization privileges to create the PR?
I want to create a PR to upgrade the repository myself to using rxjs6 as I have it done it once for our team's code base following the migration documentation:
https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md
Thanks.
from ngx-scrollspy.
where is the PR?
from ngx-scrollspy.
Update:
I have the code ready to create a PR. It's about time before it gets reviewed and committed. Thanks.
from ngx-scrollspy.
I need commit privileges. Sent you a direct email.
from ngx-scrollspy.
Usualy you would fork the repo and then create a PR. https://help.github.com/articles/creating-a-pull-request-from-a-fork/
But ill give you access to the main repo.
from ngx-scrollspy.
PR is ready:
#189
Thanks @JonnyBGod
from ngx-scrollspy.
Thank you for your contribution.
from ngx-scrollspy.
Related Issues (20)
- Please support us small suggestion, how to use scrollspy?! HOT 1
- angular 2 can't solve scrollspy HOT 6
- Does Spy any element scroll can do this ? HOT 9
- Unable to get ScrollSpyInfiniteDirective to work HOT 7
- Spying on an element doesn't resolve. HOT 4
- Replacing Bootstrap JS Scrollspy
- Does not work with angular universal HOT 1
- How to use this plugin with scrollspy bootstrap 4.0 list. HOT 4
- How to make a Scrollbox with Scrollspy
- No Idea how to use this
- ScrollSpyService should accept Observable<any> as well
- Next release for Angular 5 HOT 2
- Parallax does not work HOT 1
- Affix not working on Angular 5 HOT 1
- index.js:27 Uncaught TypeError: core_1.OpaqueToken is not a constructor HOT 1
- ScrollSpyElementDirective import causing error in browser. HOT 1
- cli
- ngx-scrollspy destroys previous url query parameters after anchor tag is clicked HOT 1
- Better looking scrollSpy-index-render
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-scrollspy.