Giter Site home page Giter Site logo

Comments (9)

JonnyBGod avatar JonnyBGod commented on August 16, 2024 3

Should be fix with https://github.com/JonnyBGod/ngx-scrollspy/releases/tag/v1.2.1

from ngx-scrollspy.

sssalib42 avatar sssalib42 commented on August 16, 2024 2

Hi guys, it has been a month so far. Will someone be looking into this soon? Please let us know.

from ngx-scrollspy.

sssalib42 avatar sssalib42 commented on August 16, 2024 1

Will someone approve my PR and complete it if I do the work? Do I need special authorization privileges to create the PR?

I want to create a PR to upgrade the repository myself to using rxjs6 as I have it done it once for our team's code base following the migration documentation:
https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md

Thanks.

from ngx-scrollspy.

JonnyBGod avatar JonnyBGod commented on August 16, 2024 1

where is the PR?

from ngx-scrollspy.

sssalib42 avatar sssalib42 commented on August 16, 2024

Update:
I have the code ready to create a PR. It's about time before it gets reviewed and committed. Thanks.

from ngx-scrollspy.

sssalib42 avatar sssalib42 commented on August 16, 2024

I need commit privileges. Sent you a direct email.

from ngx-scrollspy.

JonnyBGod avatar JonnyBGod commented on August 16, 2024

Usualy you would fork the repo and then create a PR. https://help.github.com/articles/creating-a-pull-request-from-a-fork/

But ill give you access to the main repo.

from ngx-scrollspy.

sssalib42 avatar sssalib42 commented on August 16, 2024

PR is ready:
#189
Thanks @JonnyBGod

from ngx-scrollspy.

JonnyBGod avatar JonnyBGod commented on August 16, 2024

Thank you for your contribution.

from ngx-scrollspy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.