Giter Site home page Giter Site logo

Comments (7)

jonschlinkert avatar jonschlinkert commented on June 6, 2024

yeah @doowb and I both noticed the issues afterwards. sorry about that, I'll mark as a bug.

from is-match.

tunnckoCore avatar tunnckoCore commented on June 6, 2024

okey, want PR?

And why is that https://github.com/jonschlinkert/is-match/blob/master/index.js#L31?

from is-match.

jonschlinkert avatar jonschlinkert commented on June 6, 2024

pr would be great, thanks!

And why is that https://github.com/jonschlinkert/is-match/blob/master/index.js#L31?

do you mean why the comparison? e.g. length !== 0? the main mm function returns an array of matches, so this was a quick way of determining if any matches were found. but truthfully it's probably a lazy way to do it. if you want to rethink how the matching is done with anything in this lib, I'd love to see what you come up with.

from is-match.

tunnckoCore avatar tunnckoCore commented on June 6, 2024

No, I mean, why you set to use mm when incoming is string, its no sense for me and we should continue using .isMatch when incoming pattern is string.

from is-match.

tunnckoCore avatar tunnckoCore commented on June 6, 2024

I think we should use mm when pattern is array, mm.isMatch when it is a string, deepEqual when it is an object. I think that was the idea behind last changes.

I'll come up with some thing later today.

from is-match.

tunnckoCore avatar tunnckoCore commented on June 6, 2024

Oooh, I got the idea behind L31. As it is currently var isMatch = matcher(string) isMatch supports array values to match against string pattern. Clear.

Okey I'll PR later today.

from is-match.

tunnckoCore avatar tunnckoCore commented on June 6, 2024

mm i forgot about that, i can come to it today or tomorrow.

from is-match.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.