author fields not being parsed correctly

[jonschlinkert]

author fields not being parsed correctly

[pdehaan]

Just for giggles, here's the full version of my normalized package.json file:

{
  "name": "pkg2",
  "version": "0.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": {
    "name": "Peter deHaan <[email protected]> (http://nodeexamples.com/)",
    "url": ""
  },
  "repository": {
    "type": "",
    "url": ""
  },
  "bugs": {
    "url": ""
  },
  "licenses": [
    {
      "type": "WTFPL"
    }
  ],
  "keywords": []
}

And the pre-normalized version was:

{
  "name": "pkg2",
  "version": "0.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "Peter deHaan <[email protected]> (http://nodeexamples.com/)",
  "license": "WTFPL"
}

[jonschlinkert]

Here, look what I did with Verb: https://github.com/assemble/verb/blob/master/lib/utils/authors.js

I'll move that into a separate repo and use that to parse the author field. It didn't occur to me to do that for some reason. We can also look for an AUTHORS file and conditionally use the results from that (like if the authors field is missing and/or to fill in missing data, etc)

[jonschlinkert]

is this technically a bug, or a request to parse the string?

[pdehaan]

I think it's a bug as it is currently.
I'm using the shorthand notation to specify a name/email/url (Peter deHaan <[email protected]> (http://nodeexamples.com/)), but we're currently just treating it as a name.

[doowb]

The normalized author field is now the string version so it's not expanded into an object.