Giter Site home page Giter Site logo

Comments (3)

joost avatar joost commented on August 21, 2024

For me it works, see spec.

from phony_rails.

p0wl avatar p0wl commented on August 21, 2024

Thanks for the fast response and your work!

We can reproduce it when the default_country_code is matching the country prefix:

The following test case fails:

    it 'should pass Github issue #170' do
      PhonyRails.default_country_code = 'DE'
      phone = '(+49) 175 123 4567'
      phone = PhonyRails.normalize_number(phone)
      expect(phone).to eq('+491751234567')
    end

it is passing when default_country_code is set to anything other than 'DE'.

from phony_rails.

p0wl avatar p0wl commented on August 21, 2024

Hey @joost, I saw that the new version (v0.14.7) includes your spec for this issue. But as said, your spec does not cover our issue. The spec should be different:

    it 'should pass Github issue #170' do
      PhonyRails.default_country_code = 'DE'
      phone = '(+49) 175 123 4567'
      phone = PhonyRails.normalize_number(phone)
      expect(phone).to eq('+491751234567')
    end

Can you please change the spec? Thanks!

from phony_rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.