Infinite 'joplin.data.get' loop when configuring the Email plugin

[joplin]

Infinite 'joplin.data.get' loop when configuring the Email plugin

[chopstik]

@bishoy-magdy are you able to produce a new release from the latest code? The current 1.0.0 release is out of date and leading to loading/loop issues.

[founfabug]

@bishoy-magdy Thank you for this plugin, it is the reason I moved from tidliwiki to Joplin. Could you please make a new release of the plugin from the latest code?

[adeverteuil]

I think I found the bug. In the source code, the plugin attempts to get all the folders like this:

    let joplinFolders: JopinFolders;
    const folders = [];

    do {
        joplinFolders = await joplin.data.get(['folders']);

        [build internal index of folders...]
        }
    } while (joplinFolders.has_more);

However, this is not the correct way to make paginated request; the page query parameter is missing. When there are more than 100 items to return and joplinFolders.has_more is true, only page 1 is requested and the plugin enters an infinite loop.

I think this would work better:

    let joplinFolders: JopinFolders;
    const folders = [];
    let pageNum = 1;

    do {
        joplinFolders = await joplin.data.get(['folders'], {"page": pageNum++});

        [build internal index of folders...]
        }
    } while (joplinFolders.has_more);

Please note that I have not tested this and I'm not a Typescript or a Javascript programmer.

I also found two places in src/ui/screens.ts where this infinite loop may happen:

plugin-email/src/ui/screens.ts

Line 207 in 34fe1a4

joplinFolders = await joplin.data.get(['folders']);

plugin-email/src/ui/screens.ts

Line 331 in 34fe1a4

joplinFolders = await joplin.data.get(['folders']);

References:

• https://joplinapp.org/api/references/rest_api/#pagination
• https://joplinapp.org/api/references/plugin_api/classes/joplindata.html

[bishoy-magdy]

Hi @adeverteuil, Thanks very much for this great description of the issue.

However, this is not the correct way to make paginated request; the page query parameter is missing. When there are more than 100 items to return and joplinFolders.has_more is true, only page 1 is requested and the plugin enters an infinite loop.

This is correct; the bug occurs when the number of folders is greater than 100. I will fix it, and thank you for mentioning it.

To be sure, this is the issue you encounter. Is the login button going to always spin infinity, and you unable to login?

[adeverteuil]

Hi @bishoy-magdy, thank you for your response!

Is the login button going to always spin infinity, and you unable to login?

Yes, when I click on the Login button, then it changes to a Loading spinner that spins infinitely, and I am unable to login.

Here is a screenshot: