Comments (1)
Hi @rogiervandongen ! I appreciate the detailed explanation, thank you for looking into this.
To confirm your assumption about which calorie unit is described by Calorie
, the answer is yes, the code is in reference to the thermochemical calorie.
If/when fixed, it's also highly advisable to make an explicit note which specific calorie definition is meant.
Since you seem to have some strong knowledge in this area of units (no pun intended), I would be more than happy to review a PR from you. :) "If/when" is entirely up to you, mate. From what I gather in your description of the problem you encountered, the fix might be
- some adjustments to one or more energy unit base values;
- possibly rename the calorie unit to better communicate what it measures;
- add additional energy units?;
from unit-converter.
Related Issues (20)
- registry tramples units with the same symbol HOT 2
- Refactor tests HOT 2
- Regression after merge #fix-127-trampled-units HOT 2
- Symbol is bad identificator HOT 2
- update namespacing so that `src/UnitConverter/` subdirectory is not needed HOT 1
- add functionality to give answer as a worded number
- Add `.gitattributes` to project to prevent exporting test sources, artifacts, as well as PHARs committed to the repository HOT 4
- Electricity/Energy Values Inquiry HOT 1
- ErrorException: bcmul(): bcmath function argument is not well-formed HOT 6
- type check for numeric input to prevent calculator exceptions HOT 1
- update php documenter and fix compile errors
- Replace Robo with Make
- Adopt Pest testing framework HOT 1
- use docker to containerize development environment
- BinaryCalculator is not working in a correct way HOT 3
- CoversionFormula throws a TypeError HOT 3
- PHP 8.1 compatibility: `UnitConverter\Support\Collection::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed`
- PHP 8.2 compatibility HOT 2
- Relax `ext-bcmath` requirement in composer.json and instead add checks when attempting to use BinaryCalculator HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unit-converter.