Comments (14)
Ok, so for breaks and services we shouldn't have the bookmark option ? From what I see, the bookmark option is visible because the breaks for Android Makers have the service type. If the type was correct, the option wouldn't be visible.
if (!session.isBreak()) {
Bookmark(
isBookmarked = isBookmarked,
onBookmarkChange = { shouldAdd ->
if (!isLoggedIn) {
showDialog = true
return@Bookmark
}
if (shouldAdd) {
addBookmark(session.id)
} else {
removeBookmark(session.id)
}
}
)
}
from confetti.
You can check this pull request for the code I wrote : #1314
from confetti.
That's merged now
from confetti.
ah, thanks....that does look pretty ugly all right :)
from confetti.
If service sessions are white (on light mode) what would be the correct color in dark mode ?
from confetti.
I"m not sure tbh what best colour would be to use there (am definitely not a designer :) ) ....maybe one of standard ones with some change in alpha or perhaps tonalElevation as we do with ConfettiHeaderAndroid
for example
from confetti.
Something like this for example ?
from confetti.
Yeah, that definitely looks better....also btw just noticed we show bookmark option for those which I guess we shouldn't!
from confetti.
Sorry, I'm also definitely not a designer 😅 - but on the proposed screenshots above, it looks like the break/service sessions are actually highlighted and have an importance higher than the other sessions whereas, arguably, it's the opposite 😅
They should probably have the same color as the background instead.
from confetti.
Ok 😄, I'm going to try to find a dimmer color (background on dark theme gives me a full black list 😅 )
from confetti.
I'm not super familiar with options here but wondering what tonalElevation
might add
from confetti.
I will look into it 👍
from confetti.
Here's with a tonalElevation of 8dp for sessions and 0dp for services :
![](https://private-user-images.githubusercontent.com/526001/326426742-f9923ff2-0cba-408d-86e2-ed26ecf723dc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5ODU5NzksIm5iZiI6MTcxNzk4NTY3OSwicGF0aCI6Ii81MjYwMDEvMzI2NDI2NzQyLWY5OTIzZmYyLTBjYmEtNDA4ZC04NmUyLWVkMjZlY2Y3MjNkYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxMFQwMjE0MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hZmQ0Yjc3MWNlNWE4MWRmYTBmMzVmYWIwZjg0NWFkZmFkMzA5MWU0ZWNjNTdjMGI4ZjU5ZTQ5NDQwNmYyYTljJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.QxIRJs05SgboJ4izKwmUjjdceWzoPnbCA5Y7JTnDrss)
![](https://private-user-images.githubusercontent.com/526001/326426993-a65a077d-c299-4562-83b4-02eaa5fee62a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5ODU5NzksIm5iZiI6MTcxNzk4NTY3OSwicGF0aCI6Ii81MjYwMDEvMzI2NDI2OTkzLWE2NWEwNzdkLWMyOTktNDU2Mi04M2I0LTAyZWFhNWZlZTYyYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxMFQwMjE0MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMDljMTViMWY0NmY1MzA4MDFmNTNhYWU2NzVkMGNiNDE0Y2Y0YmYxYTZkMjMwNjExY2NjM2FkMDdkODdjOTBiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.RN2sXJ0MVEKLvUhSJU0OBff4JtVovRwvqeA7MYcMtng)
from confetti.
That definitely looks better. @BoD what you think?
from confetti.
Related Issues (20)
- Prefetch images on Wear session page
- Resizing image service HOT 1
- Use Lokalise to have more languages
- Support login on iOS HOT 1
- Scroll State is lost while switching tabs
- Experiment with strong skipping
- Web client 🌍 HOT 2
- Snackbar displayed behind system navigation bar
- Crash during startup without network connection HOT 3
- Login issue on Android HOT 5
- Bookmarks Notification
- Consider adding the Hacktoberfest topic/label
- Add .ics/Google Calendar
- Show Basic Venue information HOT 1
- Add Floor plan pinch/zoom etc to iOS and Android clients
- Sign in feature HOT 1
- Why not use TabView instead of buttons in row ? HOT 3
- Watchos compose HOT 2
- Make ordering of sessions at particular time deterministic
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from confetti.